Skip to content

Commit 6069143

Browse files
chmoueltheakshaypant
authored andcommitted
fix: Add target ns annotation to on-tag
We missed it and this was causing all soft of issues when running the tests, like this error: "test/gitlab_merge_request_test.go:687", "msg":"Changing Title on MergeRequest https://gitlab.pipelinesascode.com/pac/e2e-testing/-/merge_requests/184"} gitlab_merge_request_test.go:697: assertion failed: len(prs.Items) is not 2 --- FAIL: TestGitlabMergeRequestOnUpdateAtAndLabelChange (33.54s) Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
1 parent cf0e0f7 commit 6069143

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

test/testdata/failures/pipelinerun-invalid-cel.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ metadata:
55
name: "\\ .PipelineName //"
66
annotations:
77
pipelinesascode.tekton.dev/on-cel-expression: event == "pull request" |
8+
pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //"
89
spec:
910
pipelineSpec:
1011
tasks:

test/testdata/pipelinerun-on-tag.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ kind: PipelineRun
44
metadata:
55
name: "pipelinerun-on-tag"
66
annotations:
7+
pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //"
78
pipelinesascode.tekton.dev/on-target-branch: "[\\ .TargetBranch //]"
89
pipelinesascode.tekton.dev/on-event: "[push]"
910
spec:

0 commit comments

Comments
 (0)