fix: Stabilize sorting logic for task logs and status

The sorting logic for task logs and status did not have a stable
tie-breaker when completion or start times were identical. This resulted
in inconsistent sorting order for tasks with the same timestamp.

The `taskInfoSorter.Less` function was updated to sort by task name
alphabetically when `CompletionTime` is the same.

The `taskrunList.Less` function was updated to sort by
`PipelineTaskName` in reverse alphabetical order when `StartTime` is the
same. This ensures a consistent and predictable sorting order in all
scenarios.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

fix: More Stabilize task log snippet sorting

Modified the sorting logic for task log snippets to ensure consistent
ordering. The changes prioritize sorting by completion time (earliest
first), and then by name for tasks with the same completion time.
Running tasks, identified by a nil CompletionTime, are now consistently
placed at the end of the sorted list. This addresses edge cases where
nil completion times could lead to unpredictable sorting behavior.

Revert "fix: Stabilize task log snippet sorting"

This reverts commit 84a257f20cd70fa2657a88b2286ab555eb753522.

Author: chmouel

pkg/sort/task_log_snippets.go

@@ -15,6 +15,9 @@ func (s taskInfoSorter) Swap(i, j int) {
 }
 
 func (s taskInfoSorter) Less(i, j int) bool {
+	if s[i].CompletionTime.Equal(s[j].CompletionTime) {
+		return s[i].Name < s[j].Name
+	}
 	return s[i].CompletionTime.Before(s[j].CompletionTime)
 }
 

pkg/sort/task_log_snippets_test.go

@@ -38,6 +38,26 @@ func TestTaskInfos(t *testing.T) {
 			},
 			want: "before",
 		},
+		{
+			name: "same completion time sorts by name",
+			args: args{
+				taskinfos: map[string]pacv1alpha1.TaskInfos{
+					"task-zebra": {
+						Name: "zebra",
+						CompletionTime: &metav1.Time{
+							Time: time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC),
+						},
+					},
+					"task-alpha": {
+						Name: "alpha",
+						CompletionTime: &metav1.Time{
+							Time: time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC),
+						},
+					},
+				},
+			},
+			want: "alpha",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

pkg/sort/task_status.go

@@ -38,6 +38,9 @@ func (trs taskrunList) Less(i, j int) bool {
 		return true
 	}
 
+	if trs[i].Status.StartTime.Equal(trs[j].Status.StartTime) {
+		return trs[i].PipelineTaskName > trs[j].PipelineTaskName
+	}
 	return trs[j].Status.StartTime.Before(trs[i].Status.StartTime)
 }
 

pkg/sort/task_status_test.go

@@ -3,13 +3,15 @@ package sort
 import (
 	"regexp"
 	"testing"
+	"time"
 
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/consoleui"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params/info"
 	tektontest "github.com/openshift-pipelines/pipelines-as-code/pkg/test/tekton"
 	tektonv1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
 	"gotest.tools/v3/assert"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
 func TestStatusTmpl(t *testing.T) {
@@ -88,3 +90,40 @@ func TestStatusTmpl(t *testing.T) {
 		})
 	}
 }
+
+func TestStatusTmplSameStartTime(t *testing.T) {
+	flattedTmpl := `{{- range $taskrun := .TaskRunList }}{{- $taskrun.ConsoleLogURL }}{{- end }}`
+	wantRegexp := regexp.MustCompile(".*alpha.*zebra.*")
+
+	// Use a single shared time to ensure Equal() returns true
+	sharedTime := &metav1.Time{Time: time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC)}
+
+	prTaskRunStatus := map[string]*tektonv1.PipelineRunTaskRunStatus{
+		"zebra": {
+			PipelineTaskName: "zebra",
+			Status: &tektonv1.TaskRunStatus{
+				TaskRunStatusFields: tektonv1.TaskRunStatusFields{
+					StartTime: sharedTime,
+				},
+			},
+		},
+		"alpha": {
+			PipelineTaskName: "alpha",
+			Status: &tektonv1.TaskRunStatus{
+				TaskRunStatusFields: tektonv1.TaskRunStatusFields{
+					StartTime: sharedTime,
+				},
+			},
+		},
+	}
+
+	config := &info.ProviderConfig{
+		TaskStatusTMPL: flattedTmpl,
+	}
+	runs := params.New()
+	runs.Clients.SetConsoleUI(consoleui.FallBackConsole{})
+	pr := &tektonv1.PipelineRun{}
+	output, err := TaskStatusTmpl(pr, prTaskRunStatus, runs, config)
+	assert.NilError(t, err)
+	assert.Assert(t, wantRegexp.MatchString(output), "%s != %s", output, wantRegexp.String())
+}