fix: correctly update pending and running commit status (#2341)

* fix(gitlab): set parent status to success when CI is triggered

Set parent status to success when /ok-to-test is approved by admin.

Signed-off-by: ab-ghosh <abhi.ghosh3108@gmail.com>

Author: ab-ghosh

pkg/pipelineascode/match.go

@@ -107,6 +107,19 @@ func (p *PacRun) verifyRepoAndUser(ctx context.Context) (*v1alpha1.Repository, e
 		if allowed, err := p.checkAccessOrError(ctx, repo, status, "via "+p.event.TriggerTarget.String()); !allowed {
 			return nil, err
 		}
+		// When /ok-to-test is approved, update the parent "Pipelines as Code CI" status to success
+		// to indicate the approval was successful before pipelines start running.
+		if p.event.EventType == opscomments.OkToTestCommentEventType.String() {
+			approvalStatus := provider.StatusOpts{
+				Status:     CompletedStatus,
+				Title:      "Approved",
+				Conclusion: successConclusion,
+				DetailsURL: p.event.URL,
+			}
+			if err := p.vcx.CreateStatus(ctx, p.event, approvalStatus); err != nil {
+				p.logger.Warnf("failed to update parent status on /ok-to-test approval: %v", err)
+			}
+		}
 	}
 	return repo, nil
 }

pkg/pipelineascode/pipelineascode.go

@@ -31,6 +31,7 @@ const (
 	CompletedStatus   = "completed"
 	inProgressStatus  = "in_progress"
 	queuedStatus      = "queued"
+	successConclusion = "success"
 	failureConclusion = "failure"
 	pendingConclusion = "pending"
 	neutralConclusion = "neutral"

pkg/provider/gitlab/gitlab.go

@@ -300,6 +300,11 @@ func (v *Provider) CreateStatus(_ context.Context, event *info.Event, statusOpts
 		statusOpts.Conclusion = "success"
 		statusOpts.Title = "completed"
 	case "pending":
+		statusOpts.Conclusion = "pending"
+	}
+	// When the pipeline is actually running (in_progress), show it as running
+	// not pending. Pending is only for waiting states like /ok-to-test approval.
+	if statusOpts.Status == "in_progress" {
 		statusOpts.Conclusion = "running"
 	}
 	if statusOpts.DetailsURL != "" {