fix: decrease catalog count to fix unit tests

this commits decreases the number of want catalog
to fix the tests.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

Author: zakisk

pkg/params/settings/default_test.go

@@ -48,7 +48,7 @@ func TestGetCatalogHub(t *testing.T) {
 	}{
 		{
 			name:        "good/default catalog",
-			numCatalogs: 2,
+			numCatalogs: 1,
 			hubCatalogs: &sync.Map{},
 			httpClient:  mockHTTPClient,
 		},
@@ -59,7 +59,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-url":  "https://foo.com",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 3,
+			numCatalogs: 2,
 			hubCatalogs: &sync.Map{},
 			wantLog:     "CONFIG: setting custom hub custom, catalog https://foo.com",
 			httpClient:  mockHTTPClient,
@@ -71,7 +71,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-url":  "https://foo.com",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 3,
+			numCatalogs: 2,
 			hubCatalogs: &hubCatalog,
 			wantLog:     "",
 			httpClient:  mockHTTPClient,
@@ -83,7 +83,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-url":  "https://bar.com",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 3,
+			numCatalogs: 2,
 			hubCatalogs: &hubCatalog,
 			wantLog:     "CONFIG: setting custom hub custom, catalog https://bar.com",
 			httpClient:  mockHTTPClient,
@@ -95,7 +95,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-url":  "https://foo.com",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 3,
+			numCatalogs: 2,
 			hubCatalogs: nil,
 			wantLog:     "CONFIG: setting custom hub custom, catalog https://foo.com",
 			httpClient:  mockHTTPClient,
@@ -106,7 +106,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-id":   "custom",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 2,
+			numCatalogs: 1,
 			hubCatalogs: &sync.Map{},
 			wantLog:     "CONFIG: hub 1 should have the key catalog-1-url, skipping catalog configuration",
 			httpClient:  mockHTTPClient,
@@ -118,7 +118,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-name": "tekton",
 				"catalog-1-url":  "",
 			},
-			numCatalogs: 2,
+			numCatalogs: 1,
 			hubCatalogs: &sync.Map{},
 			wantLog:     "CONFIG: hub 1 catalog configuration have empty value for key catalog-1-url, skipping catalog configuration",
 			httpClient:  mockHTTPClient,
@@ -130,7 +130,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-url":  "https://foo.com",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 2,
+			numCatalogs: 1,
 			hubCatalogs: &sync.Map{},
 			wantLog:     "CONFIG: custom hub catalog name cannot be https, skipping catalog configuration",
 			httpClient:  mockHTTPClient,
@@ -142,7 +142,7 @@ func TestGetCatalogHub(t *testing.T) {
 				"catalog-1-url":  "/u1!@1!@#$afoo.com",
 				"catalog-1-name": "tekton",
 			},
-			numCatalogs: 2,
+			numCatalogs: 1,
 			hubCatalogs: &sync.Map{},
 			wantLog:     "catalog url /u1!@1!@#$afoo.com is not valid, skipping catalog configuration",
 			httpClient:  mockHTTPClient,