fix(github): use correct name for failed checkruns on retest

after /retest or /test command failed check run was
being wiped out because we didn't used correct
pipelinerun name before when reporting failure in
startPR func. now this uses the generateName if name
is not available for a pipelinerun.

this also adds an e2e tests to ensure that checkrun
for tekton validation failed pipelinerun is not wiped
out.

https://issues.redhat.com/browse/SRVKP-10741

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

Author: zakisk

pkg/pipelineascode/pipelineascode.go

@@ -157,12 +157,17 @@ func (p *PacRun) Run(ctx context.Context) error {
 				errMsg := fmt.Sprintf("There was an error starting the PipelineRun %s, %s", match.PipelineRun.GetGenerateName(), err.Error())
 				errMsgM := fmt.Sprintf("There was an error creating the PipelineRun: <b>%s</b>\n\n%s", match.PipelineRun.GetGenerateName(), err.Error())
 				p.eventEmitter.EmitMessage(repo, zap.ErrorLevel, "RepositoryPipelineRun", errMsg)
+				prName := match.PipelineRun.GetName()
+				if prName == "" {
+					prName = match.PipelineRun.GetGenerateName()
+				}
 				createStatusErr := p.vcx.CreateStatus(ctx, p.event, provider.StatusOpts{
-					PipelineRunName:          match.PipelineRun.GetName(),
+					PipelineRunName:          prName,
 					PipelineRun:              match.PipelineRun,
 					OriginalPipelineRunName:  match.PipelineRun.GetAnnotations()[keys.OriginalPRName],
 					Status:                   CompletedStatus,
 					Conclusion:               failureConclusion,
+					Title:                    "pipelinerun start failure",
 					Text:                     errMsgM,
 					DetailsURL:               p.run.Clients.ConsoleUI().URL(),
 					InstanceCountForCheckRun: i,

pkg/provider/github/status.go

@@ -397,7 +397,9 @@ func (v *Provider) CreateStatus(ctx context.Context, runevent *info.Event, statu
 		statusOpts.Title = "Success"
 		statusOpts.Summary = "has <b>successfully</b> validated your commit."
 	case "failure":
-		statusOpts.Title = "Failed"
+		if statusOpts.Title == "" {
+			statusOpts.Title = "Failed"
+		}
 		statusOpts.Summary = "has <b>failed</b>."
 	case "pending":
 		// for concurrency set title as pending

test/github_pullrequest_retest_test.go

@@ -6,6 +6,7 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"strings"
 	"testing"
 
 	"github.com/google/go-github/v81/github"
@@ -145,3 +146,61 @@ func TestGithubSecondPullRequestGitopsCommentCancel(t *testing.T) {
 	assert.Equal(t, succeededCount, 2, "should have two succeeded PipelineRuns")
 	assert.Equal(t, unknownCount, 0, "should have zero unknown PipelineRuns: %+v", pruns.Items)
 }
+
+func TestGithubRetestWithMultipleFailedPipelineRuns(t *testing.T) {
+	ctx := context.Background()
+	g := &tgithub.PRTest{
+		Label: "Github Retest with multiple failed PipelineRuns",
+		YamlFiles: []string{
+			"testdata/pipelinerun-tekton-validation.yaml",
+			"testdata/failures/pipelinerun-exit-1.yaml", // failed pipelinerun to be re-trigger after retest
+		},
+		NoStatusCheck: true,
+	}
+	g.RunPullRequest(ctx, t)
+	defer g.TearDown(ctx, t)
+
+	err := twait.UntilPipelineRunCreated(ctx, g.Cnx.Clients, twait.Opts{
+		RepoName:        g.TargetNamespace,
+		Namespace:       g.TargetNamespace,
+		MinNumberStatus: 1,
+		TargetSHA:       g.SHA,
+		PollTimeout:     twait.DefaultTimeout,
+	})
+	assert.NilError(t, err)
+
+	pruns, err := g.Cnx.Clients.Tekton.TektonV1().PipelineRuns(g.TargetNamespace).List(ctx, metav1.ListOptions{
+		LabelSelector: fmt.Sprintf("%s=%s", keys.SHA, g.SHA),
+	})
+	assert.NilError(t, err)
+	assert.Equal(t, len(pruns.Items), 1)
+
+	_, _, err = g.Provider.Client().Issues.CreateComment(ctx,
+		g.Options.Organization,
+		g.Options.Repo,
+		g.PRNumber,
+		&github.IssueComment{Body: github.Ptr("/retest")},
+	)
+	assert.NilError(t, err)
+
+	// here we only need to check that we have two failed check runs and nothing is gone
+	// after making the retest comment.
+	res, _, err := g.Provider.Client().Checks.ListCheckRunsForRef(ctx,
+		g.Options.Organization,
+		g.Options.Repo,
+		g.SHA,
+		&github.ListCheckRunsOptions{},
+	)
+	assert.NilError(t, err)
+
+	assert.Equal(t, len(res.CheckRuns), 2)
+
+	containsFailedPLRName := false
+	for _, checkRun := range res.CheckRuns {
+		// check if the check run is for the validation failed pipelinerun
+		if strings.Contains(checkRun.GetExternalID(), "pipelinerun-tekton-validation") {
+			containsFailedPLRName = true
+		}
+	}
+	assert.Equal(t, containsFailedPLRName, true)
+}

test/testdata/pipelinerun-tekton-validation.yaml

@@ -0,0 +1,20 @@
+---
+apiVersion: tekton.dev/v1beta1
+kind: PipelineRun
+metadata:
+  name: "\\ .PipelineName //"
+  annotations:
+    pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //"
+    pipelinesascode.tekton.dev/on-target-branch: "[\\ .TargetBranch //]"
+    pipelinesascode.tekton.dev/on-event: "[\\ .TargetEvent //]"
+spec:
+  pipelineSpec:
+    tasks:
+      - name: task
+        taskSpec:
+          stepsos:
+            - name: step
+              image: registry.access.redhat.com/ubi9/ubi-micro
+              script: |
+                echo "HELLOMOTO"
+                exit 0