Skip to content

Commit adef350

Browse files
zakiskpipelines-as-code[bot]
authored andcommitted
fix: E2E tests failure on nightly
fixed E2E test flake failure in nightly on TestGithubPacCli test Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
1 parent 9256978 commit adef350

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

test/github_tkn_pac_cli_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"context"
88
"fmt"
99
"net/http"
10-
"os"
1110
"strings"
1211
"testing"
1312
"time"
@@ -27,9 +26,6 @@ import (
2726
)
2827

2928
func TestGithubPacCli(t *testing.T) {
30-
if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
31-
t.Skip("Skipping test since only enabled for nightly")
32-
}
3329
targetNS := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-ns")
3430
ctx := context.Background()
3531
ctx, runcnx, opts, ghprovider, err := tgithub.Setup(ctx, false, false)
@@ -52,7 +48,7 @@ spec:
5248
taskSpec:
5349
steps:
5450
- name: task
55-
image: gcr.io/google-containers/busybox
51+
image: registry.access.redhat.com/ubi9/ubi-micro
5652
command: ["/bin/echo", "HELLOMOTO"]
5753
`, targetNS, options.MainBranch, triggertype.PullRequest.String()),
5854
}
@@ -113,7 +109,7 @@ spec:
113109
waitOpts := twait.Opts{
114110
RepoName: targetNS,
115111
Namespace: targetNS,
116-
MinNumberStatus: 0,
112+
MinNumberStatus: 1,
117113
PollTimeout: twait.DefaultTimeout,
118114
TargetSHA: sha,
119115
}

0 commit comments

Comments
 (0)