refactor: replace interface{} with any in codebase

This commit refactors the codebase by replacing instances of interface{}
with the new any type introduced in Go 1.18. This change improves code
readability and aligns with modern Go practices.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

pkg/action/patch.go

@@ -30,7 +30,7 @@ import (
 //
 // The function doubles the default retry parameters (steps, duration, factor, jitter) to handle conflicts more robustly.
 // If the patch operation fails after retries, the original PipelineRun is returned along with the error.
-func PatchPipelineRun(ctx context.Context, logger *zap.SugaredLogger, whatPatching string, tekton versioned.Interface, pr *tektonv1.PipelineRun, mergePatch map[string]interface{}) (*tektonv1.PipelineRun, error) {
+func PatchPipelineRun(ctx context.Context, logger *zap.SugaredLogger, whatPatching string, tekton versioned.Interface, pr *tektonv1.PipelineRun, mergePatch map[string]any) (*tektonv1.PipelineRun, error) {
 	if pr == nil {
 		return nil, nil
 	}

pkg/action/patch_test.go

@@ -43,9 +43,9 @@ func TestPatchPipelineRun(t *testing.T) {
 	assert.Equal(t, patchedPR.Annotations[filepath.Join(apipac.GroupName, "log-url")], "https://localhost.console/#/namespaces/namespace/pipelineruns/force-me")
 }
 
-func getLogURLMergePatch(clients clients.Clients, pr *pipelinev1.PipelineRun) map[string]interface{} {
-	return map[string]interface{}{
-		"metadata": map[string]interface{}{
+func getLogURLMergePatch(clients clients.Clients, pr *pipelinev1.PipelineRun) map[string]any {
+	return map[string]any{
+		"metadata": map[string]any{
 			"annotations": map[string]string{
 				keys.LogURL: clients.ConsoleUI().DetailURL(pr),
 			},

pkg/adapter/adapter.go

@@ -128,7 +128,7 @@ func (l listener) handleEvent(ctx context.Context) http.HandlerFunc {
 			return
 		}
 
-		var event map[string]interface{}
+		var event map[string]any
 		if string(payload) != "" {
 			if err := json.Unmarshal(payload, &event); err != nil {
 				l.logger.Errorf("Invalid event body format format: %s", err)
@@ -232,7 +232,7 @@ func (l listener) detectProvider(req *http.Request, reqBody string) (provider.In
 	log := *l.logger
 
 	// payload validation
-	var event map[string]interface{}
+	var event map[string]any
 	if err := json.Unmarshal([]byte(reqBody), &event); err != nil {
 		return nil, &log, fmt.Errorf("invalid event body format: %w", err)
 	}

pkg/adapter/adapter_test.go

@@ -48,10 +48,10 @@ func TestHandleEvent(t *testing.T) {
 	ctx = info.StoreNS(ctx, "default")
 
 	emptys := &unstructured.Unstructured{}
-	emptys.SetUnstructuredContent(map[string]interface{}{
+	emptys.SetUnstructuredContent(map[string]any{
 		"apiVersion": "route.openshift.io/v1",
 		"kind":       "Route",
-		"metadata": map[string]interface{}{
+		"metadata": map[string]any{
 			"name":      "not",
 			"namespace": "console",
 		},
@@ -218,7 +218,7 @@ func TestWhichProvider(t *testing.T) {
 	}
 	tests := []struct {
 		name          string
-		event         interface{}
+		event         any
 		header        http.Header
 		wantErrString string
 	}{

pkg/adapter/incoming_test.go

@@ -898,7 +898,7 @@ func TestApplyIncomingParams(t *testing.T) {
 			contentType: "application/json",
 			payloadBody: []byte(`{"params": {"key": "value", "other": "value"}}`),
 			params:      []string{"key", "other"},
-			expected:    apincoming.Payload{Params: map[string]interface{}{"key": "value", "other": "value"}},
+			expected:    apincoming.Payload{Params: map[string]any{"key": "value", "other": "value"}},
 		},
 	}
 

pkg/apis/incoming/incoming.go

@@ -3,7 +3,7 @@ package incoming
 import "encoding/json"
 
 type (
-	Params  map[string]interface{}
+	Params  map[string]any
 	Payload struct {
 		Params Params `json:"params"`
 	}

pkg/apis/incoming/incoming_test.go

@@ -9,7 +9,7 @@ import (
 func TestParseIncomingPayload(t *testing.T) {
 	// Test case where payload is valid JSON
 	payload := []byte(`{"params": {"key": "value"}}`)
-	expected := Payload{map[string]interface{}{"key": "value"}}
+	expected := Payload{map[string]any{"key": "value"}}
 	actual, err := ParseIncomingPayload(payload)
 	assert.NilError(t, err)
 	assert.DeepEqual(t, expected, actual)

pkg/cli/color.go

@@ -102,7 +102,7 @@ func (c *ColorScheme) Dimmed(t string) string {
 	return dimmed(t)
 }
 
-func (c *ColorScheme) Boldf(t string, args ...interface{}) string {
+func (c *ColorScheme) Boldf(t string, args ...any) string {
 	return c.Bold(fmt.Sprintf(t, args...))
 }
 
@@ -136,7 +136,7 @@ func (c *ColorScheme) BulletSpace() string {
 	return "  "
 }
 
-func (c *ColorScheme) Redf(t string, args ...interface{}) string {
+func (c *ColorScheme) Redf(t string, args ...any) string {
 	return c.Red(fmt.Sprintf(t, args...))
 }
 
@@ -147,7 +147,7 @@ func (c *ColorScheme) Yellow(t string) string {
 	return yellow(t)
 }
 
-func (c *ColorScheme) Yellowf(t string, args ...interface{}) string {
+func (c *ColorScheme) Yellowf(t string, args ...any) string {
 	return c.Yellow(fmt.Sprintf(t, args...))
 }
 
@@ -165,7 +165,7 @@ func (c *ColorScheme) Underline(t string) string {
 	return underline(t)
 }
 
-func (c *ColorScheme) Greenf(t string, args ...interface{}) string {
+func (c *ColorScheme) Greenf(t string, args ...any) string {
 	return c.Green(fmt.Sprintf(t, args...))
 }
 
@@ -179,7 +179,7 @@ func (c *ColorScheme) Gray(t string) string {
 	return gray(t)
 }
 
-func (c *ColorScheme) Grayf(t string, args ...interface{}) string {
+func (c *ColorScheme) Grayf(t string, args ...any) string {
 	return c.Gray(fmt.Sprintf(t, args...))
 }
 
@@ -190,7 +190,7 @@ func (c *ColorScheme) Magenta(t string) string {
 	return magenta(t)
 }
 
-func (c *ColorScheme) Magentaf(t string, args ...interface{}) string {
+func (c *ColorScheme) Magentaf(t string, args ...any) string {
 	return c.Magenta(fmt.Sprintf(t, args...))
 }
 
@@ -201,7 +201,7 @@ func (c *ColorScheme) Cyan(t string) string {
 	return cyan(t)
 }
 
-func (c *ColorScheme) Cyanf(t string, args ...interface{}) string {
+func (c *ColorScheme) Cyanf(t string, args ...any) string {
 	return c.Cyan(fmt.Sprintf(t, args...))
 }
 
@@ -226,7 +226,7 @@ func (c *ColorScheme) BlueBold(t string) string {
 	return blueBold(t)
 }
 
-func (c *ColorScheme) Bluef(t string, args ...interface{}) string {
+func (c *ColorScheme) Bluef(t string, args ...any) string {
 	return c.Blue(fmt.Sprintf(t, args...))
 }
 

pkg/cli/prompt/prompt.go

@@ -3,11 +3,11 @@ package prompt
 import "github.com/AlecAivazis/survey/v2"
 
 // SurveyAskOne ask one question to be stubbed later.
-var SurveyAskOne = func(p survey.Prompt, response interface{}, opts ...survey.AskOpt) error {
+var SurveyAskOne = func(p survey.Prompt, response any, opts ...survey.AskOpt) error {
 	return survey.AskOne(p, response, opts...)
 }
 
 // SurveyAsk ask questions to be stubbed later.
-var SurveyAsk = func(qs []*survey.Question, response interface{}, opts ...survey.AskOpt) error {
+var SurveyAsk = func(qs []*survey.Question, response any, opts ...survey.AskOpt) error {
 	return survey.Ask(qs, response, opts...)
 }

pkg/cli/prompt/stubber.go

@@ -22,7 +22,7 @@ func InitAskStubber() (*AskStubber, func()) {
 	origSurveyAskOne := SurveyAskOne
 	as := AskStubber{}
 
-	SurveyAskOne = func(p survey.Prompt, response interface{}, _ ...survey.AskOpt) error {
+	SurveyAskOne = func(p survey.Prompt, response any, _ ...survey.AskOpt) error {
 		as.AskOnes = append(as.AskOnes, &p)
 		count := as.OneCount
 		as.OneCount++
@@ -49,17 +49,17 @@ func InitAskStubber() (*AskStubber, func()) {
 }
 
 type StubPrompt struct {
-	Value   interface{}
+	Value   any
 	Default bool
 }
 
 type QuestionStub struct {
 	Name    string
-	Value   interface{}
+	Value   any
 	Default bool
 }
 
-func (as *AskStubber) StubOne(value interface{}) {
+func (as *AskStubber) StubOne(value any) {
 	as.StubOnes = append(as.StubOnes, &StubPrompt{
 		Value: value,
 	})