test(gitlab): use push SHA to avoid stale MR API (#2453)

GitLab's GetMergeRequest API may return stale SHA after force push.
Use SHA from PushFilesToRefGit directly instead.

Signed-off-by: Akshay Pant <akshay.akshaypant@gmail.com>

Author: theakshaypant

test/gitlab_merge_request_test.go

@@ -913,30 +913,26 @@ func TestGitlabConsistentCommitStatusOnMR(t *testing.T) {
 		BaseRefName:   projectinfo.DefaultBranch,
 		PushForce:     true,
 	}
-	_ = scm.PushFilesToRefGit(t, scmOpts, entries)
+	newSHA := scm.PushFilesToRefGit(t, scmOpts, entries)
 	runcnx.Clients.Log.Infof("Pushed good .tekton files to branch: %s", targetRefName)
 
-	// get latest MR because of last commit it is update
-	mr, _, err = glprovider.Client().MergeRequests.GetMergeRequest(projectinfo.ID, mr.IID, nil)
-	assert.NilError(t, err)
-
 	sopt = twait.SuccessOpt{
 		Title:           commitTitle,
 		OnEvent:         "Merge Request",
 		TargetNS:        targetNS,
 		NumberofPRMatch: 2,
-		SHA:             mr.SHA,
+		SHA:             newSHA,
 	}
 
 	twait.Succeeded(ctx, t, runcnx, opts, sopt)
-	labelSelector = fmt.Sprintf("%s=%s", keys.SHA, formatting.CleanValueKubernetes(mr.SHA))
+	labelSelector = fmt.Sprintf("%s=%s", keys.SHA, formatting.CleanValueKubernetes(newSHA))
 	prsNew, err = runcnx.Clients.Tekton.TektonV1().PipelineRuns(targetNS).List(ctx, metav1.ListOptions{
 		LabelSelector: labelSelector,
 	})
 	assert.NilError(t, err)
 	assert.Assert(t, len(prsNew.Items) == 2)
 
-	commitStatuses, _, err = glprovider.Client().Commits.GetCommitStatuses(projectinfo.ID, mr.SHA, &clientGitlab.GetCommitStatusesOptions{})
+	commitStatuses, _, err = glprovider.Client().Commits.GetCommitStatuses(projectinfo.ID, newSHA, &clientGitlab.GetCommitStatusesOptions{})
 	assert.NilError(t, err)
 	assert.Assert(t, len(commitStatuses) == 2)