fix(gitops-commands): parse branch vs tag by 'tag:'

Use strings.Contains(..., "tag:") instead of "tag" when deciding
between tag and branch in /retest comment parsing. Branch names like
akurlov/ROX-32966-test-tagged-rebuild were mis-parsed as tag, leaving
branchName empty and causing 'SHA is not the HEAD of master' on commit
comments.

SRVKP-10915

Signed-off-by: Shubham Mathur <shumathu@redhat.com>

Author: mathur07

pkg/provider/provider.go

@@ -139,7 +139,7 @@ func getPipelineRunAndBranchOrTagNameFromComment(typeOfComment, comment string)
 			return prName, branchName, tagName, fmt.Errorf("the GitOps comment `%s` does not contain a branch or tag word", comment)
 		}
 
-		if strings.Contains(splitText[1], "tag") {
+		if strings.Contains(splitText[1], "tag:") {
 			tagName = getBranchOrTagNameFromComment(splitText[1], "tag")
 		} else {
 			branchName = getBranchOrTagNameFromComment(splitText[1], "branch")

pkg/provider/provider_test.go

@@ -333,6 +333,13 @@ func TestGetPipelineRunAndBranchNameFromTestComment(t *testing.T) {
 			branchName: "chore/test",
 			wantError:  false,
 		},
+		{
+			name:       "branch name contains substring tag so not parsed as tag",
+			comment:    "/retest my-pipeline branch:feature-test-tagged-release",
+			prName:     "my-pipeline",
+			branchName: "feature-test-tagged-release",
+			wantError:  false,
+		},
 		{
 			name:      "different word other than branch for retest command",
 			comment:   "/retest invalidname:nightly",