test(github): use New() gh provider in tests

Provider struct literals bypass the New() constructor, leaving
the checkRunsCache map nil. Use New() consistently across test
files to ensure proper initialization.

Signed-off-by: Akshay Pant <akpant@redhat.com>

Author: theakshaypant

pkg/matcher/annotation_matcher_test.go

@@ -1623,9 +1623,8 @@ func TestMatchPipelinerunAnnotationAndRepositories(t *testing.T) {
 			ctx, _ := rtesting.SetupFakeContext(t)
 			fakeclient, mux, ghTestServerURL, teardown := ghtesthelper.SetupGH()
 			defer teardown()
-			vcx := &ghprovider.Provider{
-				Token: github.Ptr("None"),
-			}
+			vcx := ghprovider.New()
+			vcx.Token = github.Ptr("None")
 			vcx.SetGithubClient(fakeclient)
 			if tt.args.runevent.Request == nil {
 				tt.args.runevent.Request = &info.Request{Header: http.Header{}, Payload: nil}
@@ -2338,7 +2337,7 @@ func TestMatchPipelinerunByAnnotation(t *testing.T) {
 
 			eventEmitter := events.NewEventEmitter(cs.Clients.Kube, logger)
 			repo := tt.repo
-			matches, err := MatchPipelinerunByAnnotation(ctx, logger, tt.args.pruns, cs, &tt.args.runevent, &ghprovider.Provider{}, eventEmitter, repo, true)
+			matches, err := MatchPipelinerunByAnnotation(ctx, logger, tt.args.pruns, cs, &tt.args.runevent, ghprovider.New(), eventEmitter, repo, true)
 			if tt.wantErrNoFailedPipelineToRetest {
 				assert.Assert(t, err != nil, "expected ErrNoFailedPipelineToRetest")
 				assert.Assert(t, errors.Is(err, NoFailedPipelineToRetestError("/pac ")), "expected ErrNoFailedPipelineToRetest, got: %v", err)
@@ -3284,7 +3283,7 @@ func TestFilterSuccessfulTemplates(t *testing.T) {
 				return
 			}
 
-			filtered := filterSuccessfulTemplates(ctx, logger, cs, event, repo, &ghprovider.Provider{}, tt.matchedPRs)
+			filtered := filterSuccessfulTemplates(ctx, logger, cs, event, repo, ghprovider.New(), tt.matchedPRs)
 
 			// Check that the correct number of templates remain
 			assert.Equal(t, len(tt.expectedNames), len(filtered),

pkg/pipelineascode/match_test.go

@@ -557,10 +557,9 @@ func TestGetPipelineRunsFromRepo(t *testing.T) {
 			k8int := &kitesthelper.KinterfaceTest{
 				ConsoleURL: "https://console.url",
 			}
-			vcx := &ghprovider.Provider{
-				Token:  github.Ptr("None"),
-				Logger: logger,
-			}
+			vcx := ghprovider.New()
+			vcx.Token = github.Ptr("None")
+			vcx.Logger = logger
 			vcx.SetGithubClient(fakeclient)
 			pacInfo := &info.PacOpts{
 				Settings: settings.Settings{
@@ -789,7 +788,9 @@ func TestVerifyRepoAndUser(t *testing.T) {
 				func(rw http.ResponseWriter, _ *http.Request) { fmt.Fprint(rw, `{}`) },
 			)
 
-			vcx := &ghprovider.Provider{Token: github.Ptr("token"), Logger: logger}
+			vcx := ghprovider.New()
+			vcx.Token = github.Ptr("token")
+			vcx.Logger = logger
 			vcx.SetGithubClient(ghClient)
 			vcx.SetPacInfo(pacInfo)
 

pkg/pipelineascode/pipelineascode_startpr_test.go

@@ -207,11 +207,10 @@ func setupStartPRTest(t *testing.T) (*params.Run, *info.Event, *zap.SugaredLogge
 
 // setupProviderForTest creates and configures a GitHub provider for testing.
 func setupProviderForTest(cs *params.Run, logger *zap.SugaredLogger, fakeclient *github.Client, pacInfo *info.PacOpts) *ghprovider.Provider {
-	vcx := &ghprovider.Provider{
-		Run:    cs,
-		Token:  github.Ptr("test-token"),
-		Logger: logger,
-	}
+	vcx := ghprovider.New()
+	vcx.Run = cs
+	vcx.Token = github.Ptr("test-token")
+	vcx.Logger = logger
 	vcx.SetGithubClient(fakeclient)
 	vcx.SetPacInfo(pacInfo)
 	return vcx

pkg/pipelineascode/pipelineascode_test.go

@@ -662,11 +662,10 @@ func TestRun(t *testing.T) {
 					HubCatalogs:        &hubCatalogs,
 				},
 			}
-			vcx := &ghprovider.Provider{
-				Run:    cs,
-				Token:  github.Ptr("None"),
-				Logger: logger,
-			}
+			vcx := ghprovider.New()
+			vcx.Run = cs
+			vcx.Token = github.Ptr("None")
+			vcx.Logger = logger
 			vcx.SetGithubClient(fakeclient)
 			vcx.SetPacInfo(pacInfo)
 			p := NewPacs(&tt.runevent, vcx, cs, pacInfo, k8int, logger, nil)

pkg/reconciler/reconciler_test.go

@@ -71,9 +71,8 @@ func TestReconcilerReconcileKind(t *testing.T) {
 	fakeclient, mux, _, teardown := ghtesthelper.SetupGH()
 	defer teardown()
 
-	vcx := &ghprovider.Provider{
-		Token: github.Ptr("None"),
-	}
+	vcx := ghprovider.New()
+	vcx.Token = github.Ptr("None")
 
 	vcx.SetGithubClient(fakeclient)