fix: fix checking number of events in gitea tests

* Added ExpectEventsNumber field to TestOpts structure to allow tests to
  specify the exact number of expected events
* Modified test validation logic to check for the exact number of events
  instead of just checking for zero events
* Enhanced error reporting to show detailed event information when the
  expected number doesn't match
* Updated TestGiteaParamsChangedFilesCEL to use the new field

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

test/gitea_params_test.go

@@ -406,8 +406,9 @@ func TestGiteaParamsChangedFilesCEL(t *testing.T) {
 			"modified.txt":             "testdata/changed_files_modified",
 			"renamed.txt":              "testdata/changed_files_renamed",
 		},
-		CheckForStatus: "success",
-		ExpectEvents:   false,
+		CheckForStatus:     "success",
+		ExpectEvents:       false,
+		ExpectEventsNumber: 1,
 		FileChanges: []scm.FileChange{
 			{
 				FileName:   "deleted.txt",

test/pkg/gitea/test.go

@@ -27,10 +27,12 @@ import (
 	v1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
 	"github.com/tektoncd/pipeline/pkg/names"
 	"gotest.tools/v3/assert"
+	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
 type TestOpts struct {
+	ExpectEventsNumber    int
 	TargetRepoName        string
 	StatusOnlyLatest      bool
 	OnOrg                 bool
@@ -72,6 +74,17 @@ func PostCommentOnPullRequest(t *testing.T, topt *TestOpts, body string) {
 	assert.NilError(t, err)
 }
 
+func checkEvents(t *testing.T, events *corev1.EventList, topts *TestOpts) {
+	if len(events.Items) != topts.ExpectEventsNumber {
+		topts.ParamsRun.Clients.Log.Infof("%d events expected in case of failure but got %d", topts.ExpectEventsNumber, len(events.Items))
+		for event := range events.Items {
+			em := events.Items[event]
+			topts.ParamsRun.Clients.Log.Infof("Event: Reason: %s Type: %s ReportingInstance: %s Message: %s", em.Reason, em.Type, em.ReportingInstance, em.Message)
+		}
+		t.Fail()
+	}
+}
+
 func AddLabelToIssue(t *testing.T, topt *TestOpts, label string) {
 	var targetID int64
 	allLabels, _, err := topt.GiteaCNX.Client.ListRepoLabels(topt.Opts.Organization, topt.Opts.Repo, gitea.ListLabelsOptions{})
@@ -249,7 +262,7 @@ func TestPR(t *testing.T, topts *TestOpts) (context.Context, func()) {
 		}
 		assert.Assert(t, len(events.Items) != 0, "events expected in case of failure but got 0")
 	} else if !topts.SkipEventsCheck {
-		assert.Assert(t, len(events.Items) == 0, fmt.Sprintf("no events expected but got %v in %v ns, items: %+v", len(events.Items), topts.TargetNS, events.Items))
+		checkEvents(t, events, topts)
 	}
 	return ctx, cleanup
 }
@@ -369,7 +382,7 @@ func NewPR(t *testing.T, topts *TestOpts) func() {
 		}
 		assert.Assert(t, len(events.Items) != 0, "events expected in case of failure but got 0")
 	} else if !topts.SkipEventsCheck {
-		assert.Assert(t, len(events.Items) == 0, fmt.Sprintf("no events expected but got %v in %v ns, items: %+v", len(events.Items), topts.TargetNS, events.Items))
+		checkEvents(t, events, topts)
 	}
 	return cleanup
 }