chore: CI upgrades

Author: temoto

.github/dependabot.yaml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: github-actions
+    directory: "/"
+    schedule:
+      interval: monthly

.github/workflows/codeql.yml

@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v5
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2

.github/workflows/test.yaml

@@ -10,57 +10,59 @@ permissions:
 jobs:
   clean:
     # https://github.blesdmm.dns-dynamic.netmunity/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012/5
-    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
+    if: ${{ github.event_name == 'push' || github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
         with:
-          go-version: "^1"
+          go-version: stable
       - run: lint=0 script/clean
 
   bench:
     # https://github.blesdmm.dns-dynamic.netmunity/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012/5
-    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
+    if: ${{ github.event_name == 'push' || github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
         with:
-          go-version: "^1"
+          go-version: stable
       - run: script/bench
 
   lint:
     # https://github.blesdmm.dns-dynamic.netmunity/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012/5
-    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
+    if: ${{ github.event_name == 'push' || github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
         with:
-          go-version: "^1"
-      - uses: golangci/golangci-lint-action@v2
+          go-version: stable
+      - uses: golangci/golangci-lint-action@v8
+        with:
+          version: v2.5.0
 
   test:
     name: "test with Go ${{ matrix.go }}"
     # https://github.blesdmm.dns-dynamic.netmunity/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012/5
-    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
+    if: ${{ github.event_name == 'push' || github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
     strategy:
       fail-fast: false
       matrix:
         include:
-          - { go: "1.11" }
+          - { go: "1.12" }
           - { go: "1.17" }
           - { go: "1.18" }
           - { go: "^1", coverage: true }
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
         with:
           go-version: ${{ matrix.go }}
       - run: go test -race
@@ -72,9 +74,9 @@ jobs:
 
   vuln:
     # https://github.blesdmm.dns-dynamic.netmunity/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012/5
-    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
+    if: ${{ github.event_name == 'push' || github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v5
       - uses: kmulvey/govulncheck-action@main

.golangci.yml

@@ -1,20 +1,40 @@
+version: "2"
 linters:
   enable:
+    - copyloopvar
+    - decorder
+    - errcheck
     - goconst
-    - gofmt
     - gosec
-    - maligned
+    - govet
+    - ineffassign
     - prealloc
     - staticcheck
-  disable:
-    - deadcode
-    - structcheck
-    - varcheck
-
-linters-settings:
-  gofmt:
-    simplify: true
-  govet:
-    check-shadowing: true
-  maligned:
-    suggest-new: true
+    - unused
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+    rules:
+      - linters:
+          - staticcheck
+        text: "error strings should not be capitalized"
+formatters:
+  enable:
+    - gofmt
+  settings:
+    gofmt:
+      simplify: true
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

go.mod

@@ -1,5 +1,5 @@
 module github.com/temoto/robotstxt
 
-go 1.11
+go 1.12
 
 require github.com/stretchr/testify v1.3.0

parser.go

@@ -88,7 +88,7 @@ func (p *parser) parseAll() (groups map[string]*Group, host string, sitemaps []s
 			case lDisallow:
 				// Error if no current group
 				if len(agents) == 0 {
-					errs = append(errs, fmt.Errorf("Disallow before User-agent at token #%d.", p.pos))
+					errs = append(errs, fmt.Errorf("Disallow before User-agent at token #%d", p.pos))
 				} else {
 					isEmptyGroup = false
 					var r *rule
@@ -103,7 +103,7 @@ func (p *parser) parseAll() (groups map[string]*Group, host string, sitemaps []s
 			case lAllow:
 				// Error if no current group
 				if len(agents) == 0 {
-					errs = append(errs, fmt.Errorf("Allow before User-agent at token #%d.", p.pos))
+					errs = append(errs, fmt.Errorf("Allow before User-agent at token #%d", p.pos))
 				} else {
 					isEmptyGroup = false
 					var r *rule
@@ -123,7 +123,7 @@ func (p *parser) parseAll() (groups map[string]*Group, host string, sitemaps []s
 
 			case lCrawlDelay:
 				if len(agents) == 0 {
-					errs = append(errs, fmt.Errorf("Crawl-delay before User-agent at token #%d.", p.pos))
+					errs = append(errs, fmt.Errorf("Crawl-delay before User-agent at token #%d", p.pos))
 				} else {
 					isEmptyGroup = false
 					delay := time.Duration(li.vf * float64(time.Second))
@@ -182,8 +182,8 @@ func (p *parser) parseLine() (li *lineInfo, err error) {
 				// Must compile a regexp, this is a pattern.
 				// Escape string before compile.
 				t2 = regexp.QuoteMeta(t2)
-				t2 = strings.Replace(t2, `\*`, `.*`, -1)
-				t2 = strings.Replace(t2, `\$`, `$`, -1)
+				t2 = strings.ReplaceAll(t2, `\*`, `.*`)
+				t2 = strings.ReplaceAll(t2, `\$`, `$`)
 				if r, e := regexp.Compile(t2); e != nil {
 					return nil, e
 				} else {