feat: Add AmazonEKSVPCResourceController to cluster policy to be able to set AWS Security Groups for pod#1011
Merged
barryib merged 1 commit intoOct 4, 2020
Conversation
…y groups per pod.
toneill818
changed the title
m-barthelemy
approved these changes
Sep 17, 2020
m-barthelemy
left a comment
m-barthelemy
left a comment
There was a problem hiding this comment.
This accomplishes exactly what is requested in the official AWS doc, nothing less, nothing more.
Chili-Man
approved these changes
Sep 23, 2020
barryib
changed the title
barryib
approved these changes
Oct 4, 2020
Member
|
Thanks @toneill818 for your contribution. |
barryib
changed the title
4 tasks
barryib
pushed a commit
to Polyconseil/terraform-aws-eks
that referenced
this pull request
Oct 25, 2020
… to set AWS Security Groups for pod (terraform-aws-modules#1011) Co-authored-by: Thomas O'Neill <toneill@new-innov.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
AWS recently added the ability to assign security groups to pods, more info about this can be found here. This new feature requires an additional policy attached to the cluster role.
Checklist