Skip to content

improvement: Make the cpu_credits optional for workers launch template#1030

Merged
barryib merged 3 commits into
terraform-aws-modules:masterfrom
gillg:fix-cpu-credits-usage
Oct 5, 2020
Merged

improvement: Make the cpu_credits optional for workers launch template#1030
barryib merged 3 commits into
terraform-aws-modules:masterfrom
gillg:fix-cpu-credits-usage

Conversation

@gillg

@gillg gillg commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

PR o'clock

Description

If you choose non bustable families in your template (c5 for example...) and you no remove credit_specification section, ASG can't start any instance.
Now you can set module cpu_credits option to null to made it fonctionnal.

Checklist

  • CI tests are passing

@gillg gillg changed the title Improvement: CPU credits could be removed from workers launch template improvement: CPU credits could be removed from workers launch template Oct 1, 2020
@gillg gillg force-pushed the fix-cpu-credits-usage branch from 356e88b to cae38a3 Compare October 1, 2020 14:53
@barryib

barryib commented Oct 4, 2020

Copy link
Copy Markdown
Member

Thanks @gillg for opening this PR. I was wondering if setting the cpu_credit to null doesn't work without your change ?

@gillg

gillg commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

Hi @barryib I tried it but it's an invalid value for aws provider API.
So the solution is to remove it

@barryib barryib changed the title improvement: CPU credits could be removed from workers launch template improvement: Make the CPU optional for workers launch template Oct 4, 2020
Comment thread workers_launch_template.tf
@barryib

barryib commented Oct 4, 2020

Copy link
Copy Markdown
Member

Hi @barryib I tried it but it's an invalid value for aws provider API.
So the solution is to remove it

Ok. Good to know. I just added one comment for the coding style. Just resolves that and we're good to go ^^.

@barryib

barryib commented Oct 4, 2020

Copy link
Copy Markdown
Member

Please rebase your branch to fix the CI.

@barryib barryib self-assigned this Oct 4, 2020
@barryib barryib added this to the v13.0.0 milestone Oct 4, 2020
@gillg gillg force-pushed the fix-cpu-credits-usage branch from cae38a3 to 91c9823 Compare October 4, 2020 20:41
@gillg

gillg commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

Everything is ok !

@barryib barryib left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gillg for your contribution.

@barryib barryib changed the title improvement: Make the CPU optional for workers launch template improvement: Make the cpu_credits optional for workers launch template Oct 5, 2020
@barryib barryib merged commit 93614b3 into terraform-aws-modules:master Oct 5, 2020
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
…ate (terraform-aws-modules#1030)

NOTES: `credit_specification` for worker groups launch template can now be set to `null` so that we can use non burstable EC2 families
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants