improvement: Make the cpu_credits optional for workers launch template#1030
Conversation
356e88b to
cae38a3
Compare
|
Thanks @gillg for opening this PR. I was wondering if setting the |
|
Hi @barryib I tried it but it's an invalid value for aws provider API. |
Ok. Good to know. I just added one comment for the coding style. Just resolves that and we're good to go ^^. |
|
Please rebase your branch to fix the CI. |
…on burstable families)
cae38a3 to
91c9823
Compare
|
Everything is ok ! |
cpu_credits optional for workers launch template
…ate (terraform-aws-modules#1030) NOTES: `credit_specification` for worker groups launch template can now be set to `null` so that we can use non burstable EC2 families
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
If you choose non bustable families in your template (c5 for example...) and you no remove
credit_specificationsection, ASG can't start any instance.Now you can set module
cpu_creditsoption to null to made it fonctionnal.Checklist