Skip to content

feat: Add customizable Auto Scaling Group health check type#1118

Merged
barryib merged 2 commits into
terraform-aws-modules:masterfrom
svaranasi-corporate:ASG-health-check-type
Dec 22, 2020
Merged

feat: Add customizable Auto Scaling Group health check type#1118
barryib merged 2 commits into
terraform-aws-modules:masterfrom
svaranasi-corporate:ASG-health-check-type

Conversation

@svaranasi-corporate

@svaranasi-corporate svaranasi-corporate commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

PR o'clock

Description

Adding the ability to define health-check type for autoscaling groups. I saw this issue without a PR, so this is that.

Checklist

@svaranasi-corporate

Copy link
Copy Markdown
Contributor Author

Hello there! Just wondering if there's anything else that you need from me before you review this PR, or if it's just a wait and watch thingy.

@svaranasi-corporate

Copy link
Copy Markdown
Contributor Author

I'd love if someone could take a quick look at this PR. Please let me know if you need any further information to help this get merged. Thanks!

@svaranasi-corporate

Copy link
Copy Markdown
Contributor Author

Anybody?

@barryib barryib changed the title improvement: Customizable ASG health check type feat: Add customizable Auto Scaling Group health check type Dec 22, 2020

@barryib barryib left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svaranasi-traderev

@barryib barryib merged commit ccacc17 into terraform-aws-modules:master Dec 22, 2020
@svaranasi-corporate svaranasi-corporate deleted the ASG-health-check-type branch March 19, 2021 08:44
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants