Skip to content

feat: Use gp3 as default as it saves 20% and is more performant#1134

Merged
barryib merged 5 commits into
terraform-aws-modules:masterfrom
jayzalowitz:master
Jan 28, 2021
Merged

feat: Use gp3 as default as it saves 20% and is more performant#1134
barryib merged 5 commits into
terraform-aws-modules:masterfrom
jayzalowitz:master

Conversation

@jayzalowitz

@jayzalowitz jayzalowitz commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

PR o'clock

Provider has caught up hashicorp/terraform-provider-aws#16652, thanks @ewbankkit

Description

AWS now has a cheaper and more performant drive type:
https://aws.amazon.com/about-aws/whats-new/2020/12/introducing-new-amazon-ebs-general-purpose-volumes-gp3/
Re: #1130

Checklist

@jayzalowitz jayzalowitz changed the title Add gp3 as default as it saves 20% and is more performant fix: Add gp3 as default as it saves 20% and is more performant Dec 3, 2020
@jayzalowitz

Copy link
Copy Markdown
Contributor Author

@antonbabenko Any suggestion on getting that pull request linter working?

@barryib barryib changed the title fix: Add gp3 as default as it saves 20% and is more performant feat: Use gp3 as default as it saves 20% and is more performant Dec 22, 2020
@barryib

barryib commented Dec 23, 2020

Copy link
Copy Markdown
Member

This is a breking change. I will include this in the next major release (It's on his way ^^).

@barryib barryib merged commit 76537d1 into terraform-aws-modules:master Jan 28, 2021
barryib added a commit that referenced this pull request Jan 29, 2021
@barryib

barryib commented Jan 29, 2021

Copy link
Copy Markdown
Member

I'm going to revert this change, since it breaks launch configuration usage. See #1205 for more info.

cc @jayzalowitz

@marcusramberg

Copy link
Copy Markdown

Just hit this bug, any chance of a new release with that revert?

@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants