Skip to content

improvement: Dont set -x in userdata to avoid printing sensitive informations in logs#1187

Merged
barryib merged 3 commits into
terraform-aws-modules:masterfrom
myoung34:bash_set
Jan 28, 2021
Merged

improvement: Dont set -x in userdata to avoid printing sensitive informations in logs#1187
barryib merged 3 commits into
terraform-aws-modules:masterfrom
myoung34:bash_set

Conversation

@myoung34

Copy link
Copy Markdown
Contributor

PR o'clock

Description

Resolves #1186

Checklist

@myoung34 myoung34 changed the title Dont set -x in userdata fix: Dont set -x in userdata Jan 18, 2021
@myoung34

Copy link
Copy Markdown
Contributor Author

@antonbabenko Any hope for a review?

@antonbabenko

Copy link
Copy Markdown
Member

@myoung34 I am not so much involved in the development and release process of this particular module, so let's wait for @barryib who has been the leading force in this one for a rather long time.

@barryib barryib changed the title fix: Dont set -x in userdata improvement: Dont set -x in userdata to avoid printing sensitive informations in logs Jan 28, 2021
@barryib barryib merged commit 84a3761 into terraform-aws-modules:master Jan 28, 2021
@myoung34 myoung34 deleted the bash_set branch January 28, 2021 22:55
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not set -x for bash userdata

5 participants