Skip to content

docs: update helm instructions for irsa example#1251

Merged
barryib merged 2 commits into
terraform-aws-modules:masterfrom
twstewart42:master
Apr 19, 2021
Merged

docs: update helm instructions for irsa example#1251
barryib merged 2 commits into
terraform-aws-modules:masterfrom
twstewart42:master

Conversation

@twstewart42

@twstewart42 twstewart42 commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

Documentation: update helm instructions for irsa example

Description

Instructions in the IRSA example installed a deprecated version of the autoscaler Helm Chart

With Previous Instructions

helm install cluster-autoscaler --namespace kube-system autoscaler/cluster-autoscaler-chart --values .\irsa-autoscaler-helm-values-example.yaml
WARNING: This chart is deprecated
NAME: cluster-autoscaler
LAST DEPLOYED: Mon Feb 22 08:28:37 2021
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
To verify that cluster-autoscaler has started, run:

With New Instructions

helm install cluster-autoscaler --namespace kube-system autoscaler/cluster-autoscaler --values .\irsa-autoscaler-helm-values-example.yaml
NAME: cluster-autoscaler
LAST DEPLOYED: Mon Feb 22 07:43:33 2021
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
To verify that cluster-autoscaler has started, run:

  kubectl --namespace=kube-system get pods -l "app.kubernetes.io/name=aws-cluster-autoscaler,app.kubernetes.io/instance=cluster-autoscaler"

@twstewart42 twstewart42 changed the title update helm instructions for irsa example Documentation: update helm instructions for irsa example Feb 22, 2021
@daroga0002

Copy link
Copy Markdown
Contributor

@twstewart42 please change subject of PR to:
docs: update helm instructions for irsa example

as Semantic Pull Request CI failing

@twstewart42 twstewart42 changed the title Documentation: update helm instructions for irsa example Docs: update helm instructions for irsa example Feb 24, 2021
@twstewart42 twstewart42 changed the title Docs: update helm instructions for irsa example docs: update helm instructions for irsa example Feb 24, 2021
@barryib barryib merged commit b752b1d into terraform-aws-modules:master Apr 19, 2021
barryib pushed a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants