fix: limit cluster_name when creating fargate IAM Role#1270
Merged
barryib merged 2 commits intoApr 19, 2021
Merged
Conversation
gugacavalieri
changed the title
2 tasks
stijndehaes
approved these changes
Mar 26, 2021
Contributor
Author
|
Thanks @stijndehaes ! I don't know why CI is failing on the |
barryib
approved these changes
Apr 19, 2021
barryib
pushed a commit
to barryib/terraform-aws-eks
that referenced
this pull request
May 20, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
This PR resolves #1268 😄
This will always limit the
aws_iam_role.eks_fargate_pod.name_prefixattribute to 32 chars. If thecluster_namevariable is shorter than 24 chars, it will use the full string instead.Checklist