Skip to content

fix: Add description for private API ingress Security Group Rule#1299

Merged
barryib merged 3 commits into
terraform-aws-modules:masterfrom
mitom:fix/sg_description
May 19, 2021
Merged

fix: Add description for private API ingress Security Group Rule#1299
barryib merged 3 commits into
terraform-aws-modules:masterfrom
mitom:fix/sg_description

Conversation

@mitom

@mitom mitom commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

PR o'clock

Description

Adds a description for the SG rule for ingress to the k8s api as this is currently failing https://tfsec.dev/docs/aws/AWS018/

Checklist

@mitom mitom marked this pull request as ready for review April 13, 2021 11:24
@barryib barryib self-assigned this May 19, 2021
@barryib barryib changed the title fix: add description for private API ingress sg rule fix: Add description for private API ingress Security Group Rule May 19, 2021
@barryib

barryib commented May 19, 2021

Copy link
Copy Markdown
Member

Thanks @mitom for your contribution.

@barryib barryib merged commit a639cf5 into terraform-aws-modules:master May 19, 2021
barryib pushed a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants