Skip to content

feat: Allow interface_type to be specified in worker_groups_launch_template#1439

Merged
antonbabenko merged 2 commits into
terraform-aws-modules:masterfrom
nimbix:master
Oct 7, 2021
Merged

feat: Allow interface_type to be specified in worker_groups_launch_template#1439
antonbabenko merged 2 commits into
terraform-aws-modules:masterfrom
nimbix:master

Conversation

@paulbsch

@paulbsch paulbsch commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

…e passed into worker_groups_launch_template.

PR o'clock

Description

This really simple PR allows setting the "interface_type" for launch templates. This is needed to use EFA interfaces. The change doesn't appear to need and README.md updates.

Checklist

…e passed into worker_groups_launch_template.
@stale

stale Bot commented Sep 12, 2021

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@stale stale Bot added the stale label Sep 12, 2021
@stale

stale Bot commented Sep 19, 2021

Copy link
Copy Markdown

This PR has been automatically closed because it has not had recent activity since being marked as stale.
Please reopen when work resumes.

@stale stale Bot closed this Sep 19, 2021
@paulbsch

Copy link
Copy Markdown
Contributor Author

Please keep this open until this change (or something similar) is applied. There is currently no other way to specify the interface type.

@daroga0002

Copy link
Copy Markdown
Contributor

@paulbsch could you solve a conflicts?

@paulbsch

Copy link
Copy Markdown
Contributor Author

Should be good now, just let me know if I need to do anything else @daroga0002
Thanks!

@daroga0002 daroga0002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and is working fine 🚀

@paulbsch thank you for contribution

@antonbabenko this also can be merged

@antonbabenko antonbabenko changed the title improvement: Allow interface_type to be specified in worker group configs which ar… feat: Allow interface_type to be specified in worker_groups_launch_template Oct 7, 2021
@antonbabenko antonbabenko merged commit f37e5af into terraform-aws-modules:master Oct 7, 2021
lisfo4ka pushed a commit to lisfo4ka/terraform-aws-eks that referenced this pull request Oct 12, 2021
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants