fix: Rebuild examples

[daroga0002]

PR o'clock

Description

resolves #1622

This is major improvement in our examples. Some examples were broken or were not running correctly, after those fixes:

• all examples are working as should (I tested each of them)
• examples have generic README.md which can be updated more over time
• in IRSA example I automated helm autoscaler deployment in terraform (it was manual step which was error prone)
• fixed bottlerocket example where nodes were not registering to cluster (missing aws-auth configmap management)
• each example is now independent and has random suffix (so can be used multiple times on same AWS account)
• each example creates vpc and other basic resources
• core-dns is scheduled correctly in fargate example
• fixed variables description highlighted in fix description of variable "map_users" #1623
• fixed some markdown linting error in main README.md
• bump some versions.tf in examples to align with overall module
• removed _bootstrap example as it was created dependencies and in general didn't allow to run multiple examples in parallel

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[antonbabenko]

Good improvement overall!

The changes are rather big, and not all of them are in sync with the approach we have in other modules in this organization (e.g. different structures, file names, etc). I will try to find time to review it during this week.

[antonbabenko]

Hi @daroga0002 ! I reviewed it and most of the comments are applicable to all examples.

[daroga0002]

@antonbabenko I reviewed comments, some I will fix, some I answered here for discussion as I truly believe those changes should be done to make it more flexible for example for testing purposes

[daroga0002]

first round of fixes from review, there will be also second commit

[antonbabenko]

Minor comment about ordering of resources in examples. LGTM.

[antonbabenko]

Please move all supporting resources and data sources after the most important piece in the example - module "eks".

[daroga0002]

done

[daroga0002]

after this I think we can publish a release as this will be one of biggest releases for very long

[antonbabenko]

Thanks @daroga0002 !

v17.21.0 has been just released.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.