Skip to content

fix: Correct conditional map for cluster security group additional rules#1738

Merged
antonbabenko merged 1 commit into
terraform-aws-modules:masterfrom
bryantbiggs:fix/additional-sg-rules
Jan 6, 2022
Merged

fix: Correct conditional map for cluster security group additional rules#1738
antonbabenko merged 1 commit into
terraform-aws-modules:masterfrom
bryantbiggs:fix/additional-sg-rules

Conversation

@bryantbiggs

Copy link
Copy Markdown
Member

Description

  • correct conditional map for cluster security group additional rules

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    - Validated on examples/eks_managed_node_group with updated example for issue discovered

@bryantbiggs bryantbiggs changed the title fix: correct conditional map for cluster security group additional rules fix: Correct conditional map for cluster security group additional rules Jan 6, 2022
@bryantbiggs bryantbiggs marked this pull request as ready for review January 6, 2022 00:42
@antonbabenko antonbabenko merged commit a2c7caa into terraform-aws-modules:master Jan 6, 2022
antonbabenko pushed a commit that referenced this pull request Jan 6, 2022
### [18.0.1](v18.0.0...v18.0.1) (2022-01-06)

### Bug Fixes

* Correct conditional map for cluster security group additional rules ([#1738](#1738)) ([a2c7caa](a2c7caa))
@antonbabenko

Copy link
Copy Markdown
Member

This PR is included in version 18.0.1 🎉

@bryantbiggs bryantbiggs deleted the fix/additional-sg-rules branch January 6, 2022 12:18
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.0.1](terraform-aws-modules/terraform-aws-eks@v18.0.0...v18.0.1) (2022-01-06)

### Bug Fixes

* Correct conditional map for cluster security group additional rules ([#1738](terraform-aws-modules/terraform-aws-eks#1738)) ([4ef1a53](terraform-aws-modules/terraform-aws-eks@4ef1a53))
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create additional cluster security group rules

2 participants