fix: Wrong rolearn in aws_auth_configmap_yaml #1820
Merged
antonbabenko merged 5 commits intoFeb 1, 2022
Merged
Conversation
Anorlondo448
changed the title
Anorlondo448
force-pushed
the
fix_aws_auth_configmap_yaml_rolearn
branch
2 times, most recently
from
2766fd7 to
d2696d2
Compare
Anorlondo448
force-pushed
the
fix_aws_auth_configmap_yaml_rolearn
branch
from
d2696d2 to
1baa6de
Compare
bryantbiggs
approved these changes
Feb 1, 2022
bryantbiggs
left a comment
bryantbiggs
left a comment
Member
There was a problem hiding this comment.
thanks for catching this @Anorlondo448 - verified that this change is the correct output this morning. please run pre-commit run -a on your PR so the docs are updated, etc.
should be good to go with the above @antonbabenko 👍🏽
antonbabenko
pushed a commit
that referenced
this pull request
Feb 1, 2022
### [18.2.6](v18.2.5...v18.2.6) (2022-02-01) ### Bug Fixes * Wrong rolearn in aws_auth_configmap_yaml ([#1820](#1820)) ([776009d](776009d))
Member
|
This PR is included in version 18.2.6 🎉 |
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.2.6](terraform-aws-modules/terraform-aws-eks@v18.2.5...v18.2.6) (2022-02-01) ### Bug Fixes * Wrong rolearn in aws_auth_configmap_yaml ([#1820](terraform-aws-modules/terraform-aws-eks#1820)) ([1d3620e](terraform-aws-modules/terraform-aws-eks@1d3620e))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the rolearn set in aws_auth_configmap_yaml to the correct one.
Currently, the “Fargate Profile ARN” is set instead of the “Pod Execution Role ARN”, so the correct IAM policy cannot be retrieved.
Motivation and Context
Breaking Changes
Yes.
Because currently, “Fargate Profile ARN” is set in rolearn instead of “Pod Execution Role ARN”, so the correct IAM policy is It cannot be retrieved.
How Has This Been Tested?
Output aws_auth_configmap_yaml and confirmed that “Pod Execution Role ARN” is set in rolearn.