Skip to content

feat: Add launch_template_tags variable for additional launch template tags#1835

Merged
antonbabenko merged 11 commits into
terraform-aws-modules:masterfrom
kahirokunn:launch_template_tag_specifications_tags
Feb 3, 2022
Merged

feat: Add launch_template_tags variable for additional launch template tags#1835
antonbabenko merged 11 commits into
terraform-aws-modules:masterfrom
kahirokunn:launch_template_tag_specifications_tags

Conversation

@kahirokunn

@kahirokunn kahirokunn commented Feb 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

add "launch_template_ignore_changes" option

Motivation and Context

If I add a tag to var.tags, it will be added to all of them, but there was a situation where I wanted to add an arbitrary tag only to the specifications_tags of launch_template_tag, and I want to make it supported.

Breaking Changes

How Has This Been Tested?

@kahirokunn kahirokunn changed the title add launch_template_tag_specifications_tags option add "launch_template_tag_specifications_tags" option Feb 3, 2022
@kahirokunn kahirokunn changed the title add "launch_template_tag_specifications_tags" option feat: Add "launch_template_tag_specifications_tags" option Feb 3, 2022
bryantbiggs
bryantbiggs reviewed Feb 3, 2022
View reviewed changes
Comment thread modules/eks-managed-node-group/variables.tf Outdated
@bryantbiggs

bryantbiggs commented Feb 3, 2022

Copy link
Copy Markdown
Member

I almost forgot - we'll need to update self-managed node groups module as well, and then propagate those changes up to the root node_groups.tf as well - and the title should be updated to reflect - "feat: Add launch_template_tags variable for additional launch template tags"

@kahirokunn kahirokunn changed the title feat: Add "launch_template_tag_specifications_tags" option feat: Add launch_template_tags variable for additional launch template tags Feb 3, 2022
@kahirokunn

kahirokunn commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

@bryantbiggs
I think I did everything you told me to do.
But pre-commit run -a command does not complete no matter how long I wait 😢

@bryantbiggs

bryantbiggs commented Feb 3, 2022

Copy link
Copy Markdown
Member

do you have pre-commit installed? in this repo it can take quite some time - you can get around this with (executed from project root):

  • terraform fmt -recursive .
  • pre-commit run terraform_docs -a

@kahirokunn

kahirokunn commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

@bryantbiggs
It was just like you told me.
I think I've accomplished all the work I needed to!
Thx!

bryantbiggs
bryantbiggs reviewed Feb 3, 2022
View reviewed changes
Comment thread node_groups.tf Outdated
bryantbiggs
bryantbiggs reviewed Feb 3, 2022
View reviewed changes
Comment thread node_groups.tf Outdated
@kahirokunn

kahirokunn commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

@bryantbiggs how about now?

bryantbiggs
bryantbiggs requested changes Feb 3, 2022
View reviewed changes
Comment thread node_groups.tf Outdated
Comment thread node_groups.tf Outdated
kahirokunn and others added 2 commits February 3, 2022 23:29
@kahirokunn @bryantbiggs
Update node_groups.tf
d2cde13 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@kahirokunn @bryantbiggs
Update node_groups.tf
e3d9035 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@kahirokunn

kahirokunn commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

The correction was omitted.
Sorry about that.

bryantbiggs
bryantbiggs approved these changes Feb 3, 2022
View reviewed changes

@bryantbiggs bryantbiggs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your efforts @kahirokunn 🎉

good to go 👍🏽 @antonbabenko

@kahirokunn

kahirokunn commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for all the advice!
I've learned so much!

@antonbabenko antonbabenko merged commit 9186def into terraform-aws-modules:master Feb 3, 2022
antonbabenko pushed a commit that referenced this pull request Feb 3, 2022
@semantic-release-bot
chore(release): version 18.3.0 [skip ci]
2f01a36 
## [18.3.0](v18.2.7...v18.3.0) (2022-02-03)

### Features

* Add launch_template_tags variable for additional launch template tags ([#1835](#1835)) ([9186def](9186def))
@antonbabenko

antonbabenko commented Feb 3, 2022

Copy link
Copy Markdown
Member

This PR is included in version 18.3.0 🎉

baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
@baibailiha @semantic-release-bot
chore(release): version 18.3.0 [skip ci]
0115742 
## [18.3.0](terraform-aws-modules/terraform-aws-eks@v18.2.7...v18.3.0) (2022-02-03)

### Features

* Add launch_template_tags variable for additional launch template tags ([#1835](terraform-aws-modules/terraform-aws-eks#1835)) ([170ea31](terraform-aws-modules/terraform-aws-eks@170ea31))
@github-actions

github-actions Bot commented Nov 10, 2022

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kahirokunn @bryantbiggs @antonbabenko
⚡