Skip to content

feat: Add support for EC2 principal in assume worker role policy for China#827

Merged
barryib merged 2 commits into
terraform-aws-modules:masterfrom
kyriba:master
Apr 11, 2020
Merged

feat: Add support for EC2 principal in assume worker role policy for China#827
barryib merged 2 commits into
terraform-aws-modules:masterfrom
kyriba:master

Conversation

@GolubevV

@GolubevV GolubevV commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

fix: EC2 principal for EKS worker role assume policy

PR o'clock

Description

Add logic to correctly handle EC2 principal service endpoint in China region for EKS Worker role assume policy.

Checklist

@GolubevV GolubevV changed the title Add support for EC2 principal in assume worker role policy for China… fix: Add support for EC2 principal in assume worker role policy for China… Apr 9, 2020
@GolubevV GolubevV force-pushed the master branch 2 times, most recently from 1ada6ec to c8b62bb Compare April 9, 2020 21:34
Comment thread data.tf Outdated
Comment thread aws_auth.tf Outdated
@GolubevV GolubevV requested a review from barryib April 10, 2020 22:02
Comment thread data.tf
@barryib barryib changed the title fix: Add support for EC2 principal in assume worker role policy for China… feat: Add support for EC2 principal in assume worker role policy for China… Apr 11, 2020
@barryib barryib changed the title feat: Add support for EC2 principal in assume worker role policy for China… feat: Add support for EC2 principal in assume worker role policy for China Apr 11, 2020
@barryib barryib merged commit 2fd078e into terraform-aws-modules:master Apr 11, 2020
@barryib

barryib commented Apr 11, 2020

Copy link
Copy Markdown
Member

Thanks @GolubevV for your contribution.

@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants