feat: Cluster version is now a required variable.#972
Merged
dpiddockcmp merged 1 commit intoAug 14, 2020
Conversation
max-rocket-internet
approved these changes
Aug 12, 2020
max-rocket-internet
left a comment
max-rocket-internet
left a comment
Contributor
There was a problem hiding this comment.
Lint CI is failing but nice 👍
BREAKING CHANGES: `cluster_version` variable is now required.
dpiddockcmp
force-pushed
the
cluster-version
branch
from
eab41cc to
7450a42
Compare
Contributor
Author
|
CI now passes 😄 |
2 tasks
2 tasks
barryib
pushed a commit
to Polyconseil/terraform-aws-eks
that referenced
this pull request
Oct 25, 2020
…les#972) BREAKING CHANGES: `cluster_version` variable is now required.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change!
PR o'clock
Description
Remove the default value from
cluster_versionmaking it required.Stop the rush every time AWS releases a new supported kubernetes version to "upgrade the module". #949 was really a single line change that triggers a major version bump for something a user can set in a variable.
Fixes #947 (sort of)
Checklist