Skip to content

feat: Add kubernetes standard labels to avoid manual mistakes on the managed aws-auth configmap#989

Merged
barryib merged 4 commits into
terraform-aws-modules:masterfrom
gillg:add-kubernetes-cm-labels
Oct 25, 2020
Merged

feat: Add kubernetes standard labels to avoid manual mistakes on the managed aws-auth configmap#989
barryib merged 4 commits into
terraform-aws-modules:masterfrom
gillg:add-kubernetes-cm-labels

Conversation

@gillg

@gillg gillg commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Description

Add labels to avoid manual mistakes on managed configmap. It adds 2 labels :

apiVersion: v1
kind: ConfigMap
metadata:
  labels:
    app.kubernetes.io/managed-by: Terraform
    terraform.io/module: terraform-aws-modules.eks.aws
  name: aws-auth
  namespace: kube-system
data:
  mapAccounts: |
    []
  mapRoles: |
    ........
  mapUsers: |
    []

By this way and "standard" managed-by label, we know this file is provided and enforced by terraform. You should not edit it manualy.

Checklist

@daroga0002

Copy link
Copy Markdown
Contributor

@gillg CI is failing as you must change PR titlle as per https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/.github/CONTRIBUTING.md#semantic-pull-requests

I belive this will be improvment: so add this on beginning of tittle.

@gillg gillg changed the title Add labels to avoid manual mistakes on managed configmap improvement: Add labels to avoid manual mistakes on managed configmap Sep 10, 2020
@barryib barryib changed the title improvement: Add labels to avoid manual mistakes on managed configmap feat: Add kubernetes standard labels to avoid manual mistakes on the managed aws-auth configmap Oct 5, 2020

@barryib barryib left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gillg can you please rebase your branch from master and re-generate the terraform docs to fix the CI.

@gillg gillg force-pushed the add-kubernetes-cm-labels branch from d5ff0d4 to 53807c9 Compare October 5, 2020 20:59
@gillg

gillg commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Everything is OK

@gillg gillg force-pushed the add-kubernetes-cm-labels branch from 53807c9 to 4f25f5d Compare October 15, 2020 18:35
@gillg gillg requested a review from barryib October 15, 2020 18:36

@barryib barryib left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gillg for your contribution.

@barryib barryib merged commit 751c422 into terraform-aws-modules:master Oct 25, 2020
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants