feat: Add kubernetes standard labels to avoid manual mistakes on the managed aws-auth configmap#989
Merged
barryib merged 4 commits intoOct 25, 2020
Conversation
Contributor
|
@gillg CI is failing as you must change PR titlle as per https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/.github/CONTRIBUTING.md#semantic-pull-requests I belive this will be |
aws-auth configmap
barryib
approved these changes
Oct 5, 2020
d5ff0d4 to
53807c9
Compare
Contributor
Author
|
Everything is OK |
53807c9 to
4f25f5d
Compare
barryib
pushed a commit
to Polyconseil/terraform-aws-eks
that referenced
this pull request
Oct 25, 2020
…managed `aws-auth` configmap (terraform-aws-modules#989)
4 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add labels to avoid manual mistakes on managed configmap. It adds 2 labels :
By this way and "standard" managed-by label, we know this file is provided and enforced by terraform. You should not edit it manualy.
Checklist