Allow ICMP Network ACL rules#252
Merged
antonbabenko merged 4 commits intoterraform-aws-modules:terraform011from Sep 3, 2019
Merged
Allow ICMP Network ACL rules#252antonbabenko merged 4 commits intoterraform-aws-modules:terraform011from
antonbabenko merged 4 commits intoterraform-aws-modules:terraform011from
Conversation
added 2 commits
May 3, 2019 11:46
… from_port and to_port to be unset as would be logical in an ICMP rule.
donovancade
changed the title
Member
|
Hi @donovancade ! Thanks for adding this feature. v1.70.0 has been released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating VPC module to allow ICMP Network ACL rules. Since from_port and to_port are ignored for ICMP rules, allowing user to leave these fields off makes sense. We could make this more complicated and require from_port and to_port if protocol is not ICMP but that would make the module less readable.