Allow passing in EIPs for the NAT Gateways#38
Conversation
antonbabenko
left a comment
antonbabenko
left a comment
There was a problem hiding this comment.
First, thanks for the contribution! Second, could you please update the main README with a paragraph saying how to use this feature and provide sample configuration there. I don't think we need to have a dedicated example of it in "examples" directory.
| ############## | ||
| # NAT Gateway | ||
| ############## | ||
| # Workaround for interpolation not being able to "short-circuit" the evaluation of the conditional branch that doesn't end up being used |
| } | ||
|
|
||
| variable "reuse_nat_ips" { | ||
| description = "Should be true if you don't want EIPs to be created for your NAT Gateways and will instead pass them in via the external_nat_ips variable" |
There was a problem hiding this comment.
Change: external_nat_ips => external_nat_ip_ids
miguelaferreira
force-pushed
the
external-ip-nat-gateway
branch
4 times, most recently
from
126e813 to
556fb60
Compare
miguelaferreira
force-pushed
the
external-ip-nat-gateway
branch
from
556fb60 to
ce0c488
Compare
|
Thank you for taking the time to review my PR. I've pushed the changes you requested. Please let me know if there's anything else. |
|
Thanks! v1.9.0 is now released. |
|
Great! Thank you for the corrections to the documentation and the fast release of a new version. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
2 participants
This PR adds enables passing in external EIPs to be assigned to the NAT Gateways (Fixes #37).
To that end, this PR:
I have not documented the feature because I would like some input from the maintainers of the module on where to document this. If the PR is accepted, I could add the documentation to the main README file, to the existing examples, or even make a new example.