Skip to content

feat: add vpc_owner_id to outputs#428

Merged
antonbabenko merged 4 commits intoterraform-aws-modules:masterfrom
vmalinics0:master
May 25, 2020
Merged

feat: add vpc_owner_id to outputs#428
antonbabenko merged 4 commits intoterraform-aws-modules:masterfrom
vmalinics0:master

Conversation

@vmalinics0
Copy link
Copy Markdown
Contributor

Description

this will just add owner_id output to module

Motivation and Context

I use owner_id/Account ID in different policies and building dynamic variables, for example

codebuild

  buildspec = templatefile("files/buildspec.yml", {
    aws_region   = var.region,
    ecr_registry = "${module.vpc.owner_id}.dkr.ecr.${var.region}.amazonaws.com/${module.label.id}-ecr"
  })

or iam policy

"Resource": [
                "arn:aws:ecr:${var.region}:${module.vpc.owner_id}:repository/ecr-${var.plat}/influxdb",

Breaking Changes

none

How Has This Been Tested?

tested calling from other resources and modules as in example above

@vmalinics0 vmalinics0 changed the title added owner_id output (#1) feat: add owner_id to outputs Apr 8, 2020
@antonbabenko antonbabenko changed the title feat: add owner_id to outputs feat: add vpc_owner_id to outputs May 25, 2020
@antonbabenko antonbabenko merged commit 61b499a into terraform-aws-modules:master May 25, 2020
@antonbabenko
Copy link
Copy Markdown
Member

Thanks @vmalinics0 for this addition!

v2.38.0 has been just released.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants