Preserve ordering in aws_fsx_lustre_file_system's network_interface_ids

[mtpdt]

As explained in FSX lustre's documentation, the first network_interface_id is important and the primary one. So use a schema.TypeList instead of schema.TypeSet to preserve the ordering of this resource.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12181

Release note for CHANGELOG:

Change `aws_fsx_lustre_file_system's`'s `network_interface_ids` to `TypeList` to preserve ordering.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (496.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	496.407s

[ewbankkit]

Closes #14444.

[mtpdt]

@DrFaust92 is there a way to test this? The IDs returned from amazon are unique autogenerated uids, so it's a bit hard to test.

Let me know if additional work is needed on this PR.

[DrFaust92]

Looks good to me, LGTM. Thanks @mtpdt.

--- PASS: TestAccAWSFsxLustreFileSystem_basic (527.66s)

[DrFaust92]

@mtpdt. can we also add something to the docs as well to make users aware of this?

[mtpdt]

@DrFaust92 done, documentation added

[DrFaust92]

LGTM 🚀 🚀 🚀

[mtpdt]

@DrFaust92 any next steps needed on my part, or can you merge this in?

[ewbankkit]

LGTM.

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (431.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	431.057s

[breathingdust]

LGTM 🚀 Thanks @mtpdt for the implementation!

Verified acceptance tests:

make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic'
\==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_basic
--- PASS: TestAccAWSFsxLustreFileSystem_basic (491.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	494.501s

[ghost]

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!