Skip to content

Make ping retry timeout configurable for DockerClientProviderStrategy#217

Merged
rnorth merged 1 commit intotestcontainers:masterfrom
kunickiaj:environmentstrategy
Sep 21, 2016
Merged

Make ping retry timeout configurable for DockerClientProviderStrategy#217
rnorth merged 1 commit intotestcontainers:masterfrom
kunickiaj:environmentstrategy

Conversation

@kunickiaj
Copy link
Copy Markdown

Resolves #204 by increasing the timeout for ping retries.

@kunickiaj
Copy link
Copy Markdown
Author

Added system properties to configure each provider's timeout.. open to suggestions for improvement on the system property names.

@kunickiaj kunickiaj changed the title ping timeout of 1s too low in DockerClientProviderStrategy Make ping retry timeout configurable for DockerClientProviderStrategy Sep 20, 2016
Copy link
Copy Markdown
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you.

@rnorth rnorth merged commit acea6a9 into testcontainers:master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants