More customizable postgres container#220
Merged
rnorth merged 3 commits intotestcontainers:masterfrom Sep 22, 2016
Merged
Conversation
| } | ||
|
|
||
| public PostgreSQLContainer(String dockerImageName) { | ||
| public PostgreSQLContainer(final String dockerImageName) { |
Member
There was a problem hiding this comment.
use this(dockerImageName, "test", "test", "test")
Member
|
Looks good to me - just one thing. I've generally erred away from constructor args for containers (apart from specifying container image name), and gone for fluent setters instead. Is there a reason why the fluent setter pattern can't be used here? I'd prefer to be as consistent as possible... |
rnorth
approved these changes
Sep 21, 2016
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
This looks good to me - I'll check out and have a play locally, then merge. Thanks for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres docker container can be with custom database name, user name and password. Sometimes it is necessary.