Add support for https://docs.docker.com/compose/extends/ Next Try#227
Merged
rnorth merged 2 commits intotestcontainers:masterfrom Sep 25, 2016
Merged
Conversation
Contributor
Author
|
mvn clean test -Pproprietary-deps leads to |
Member
|
@sourcecase thanks. Re the proprietary-deps test, don't worry about it. These need the Oracle JDBC driver to run, which sadly isn't available in a public maven repo. This is why the module is only built with the |
rnorth
reviewed
Sep 23, 2016
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Looking pretty good to me - thank you.
| List<String> absoluteDockerComposeFiles = composeFiles.stream().map( | ||
| file -> containerPwd + "/" + file.getAbsoluteFile().getName()).collect(Collectors.toList()); | ||
| String composeFileEnvVariableValue = Joiner.on(File.pathSeparator).join(absoluteDockerComposeFiles); | ||
| logger().info("Set env COMPOSE_FILE={}", composeFileEnvVariableValue); |
Member
There was a problem hiding this comment.
Perhaps this should be at debug level?
Contributor
Author
There was a problem hiding this comment.
Yes. Changed it just now.
rnorth
approved these changes
Sep 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to pass more then one docker-compose file to the docker-compose comand as decribed here https://docs.docker.com/compose/extends/
To make this feature available in testcontainers a list of docker-compose files ahs to be passed to DockerComposeContainer.
The files have to be concatenated in the COMPOSE_FILE env variable as described here https://docs.docker.com/compose/reference/envvars/
Hi Richard,
I added some tests and this new Pull Request with less commits. mvn clean test is running green.
mvn clean test -Pproprietary-deps is not running. Do you have an idea here?
Best regards
Chris