feature/with-volumes-from support#289
Merged
rnorth merged 2 commits intotestcontainers:masterfrom Feb 12, 2017
peterbollen:feature/with-volumes-from
Merged
feature/with-volumes-from support#289rnorth merged 2 commits intotestcontainers:masterfrom peterbollen:feature/with-volumes-from
rnorth merged 2 commits intotestcontainers:masterfrom
peterbollen:feature/with-volumes-from
Conversation
bsideup
reviewed
Feb 7, 2017
| * @param otherContainer the other container object to add volumes from | ||
| * @param mode the bind mode | ||
| * @return this | ||
| */ |
Member
There was a problem hiding this comment.
IMO it should have an overloaded method with Container as a first parameter, the same as withLink
Member
|
Looks good to me - will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #244
Is this still something that could be added?