Docker for Windows: Use command-based port checker#309
Merged
Conversation
rnorth
reviewed
Mar 10, 2017
| private boolean isUsingSocketProxyOnMac() { | ||
| return DockerClientFactory.instance().isUsing(ProxiedUnixSocketClientProviderStrategy.class) | ||
| && System.getProperty("os.name").toLowerCase().contains("mac"); | ||
| private boolean isApplicable() { |
Member
There was a problem hiding this comment.
Maybe this could be named more clearly? Something like doesDockerPrematurelyListen or shouldApplyProxyWorkaround?
Member
Author
There was a problem hiding this comment.
changed to shouldCheckWithCommand, but still not sure :) Does it sound fine to you? )
rnorth
reviewed
Mar 10, 2017
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Only one comment, but LGTM otherwise
rnorth
added a commit
that referenced
this pull request
Mar 12, 2017
## [1.2.0] - 2017-03-12 ### Fixed - Fix various escaping issues that may arise when paths contain spaces (#263, #279) - General documentation fixes/improvements (#300, #303, #304) - Improve reliability of `ResourceReaper` when there are a large number of containers returned by `docker ps -a` (#295) ### Changed - Support Docker for Windows via TCP socket connection (#291, #297, #309). _Note that Docker Compose is not yet supported under Docker for Windows (see #306) - Expose `docker-java`'s `CreateContainerCmd` API for low-level container tweaking (#301) - Shade `org.newsclub` and Guava dependencies (#299, #292) - Add `org.testcontainers` label to all containers created by Testcontainers (#294)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like Docker for Windows has the same port forwarding issue as Docker for Mac