Skip to content

Cleanup if start failed#336

Merged
bsideup merged 3 commits intotestcontainers:masterfrom
tbcs:cleanup-if-start-failed
May 29, 2017
Merged

Cleanup if start failed#336
bsideup merged 3 commits intotestcontainers:masterfrom
tbcs:cleanup-if-start-failed

Conversation

@tbcs
Copy link
Copy Markdown
Contributor

@tbcs tbcs commented May 4, 2017

This is a proposed fix for #335.
The test suites reported no errors after this change.

@rnorth
Copy link
Copy Markdown
Member

rnorth commented May 6, 2017

@tbcs thanks for spotting this and raising a PR to fix.
I'll take a look at the PR today and hopefully merge in.
Thank you!
Richard

@bsideup bsideup merged commit ab56a27 into testcontainers:master May 29, 2017
@bsideup bsideup added this to the 1.3.0 milestone May 29, 2017
@bsideup
Copy link
Copy Markdown
Member

bsideup commented May 29, 2017

Hey @tbcs,

Thanks for your contribution!

May I kindly ask you to test the latest TestContainers ( by using JitPack ) and verify that your issue was fixed?
If not, you can re-open it, but hopefully it is :)

Thanks,
Sergei

@bsideup bsideup self-requested a review May 29, 2017 13:40
@tbcs
Copy link
Copy Markdown
Contributor Author

tbcs commented May 29, 2017

Hi @bsideup, I can confirm that the issue is fixed in ab56a27 (verified via com.github.testcontainers.testcontainers-java:testcontainers:ab56a27). Thanks for merging this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants