Conversation
getMappedPort overloaded methodgetFirstMappedPort method
rnorth
reviewed
Jun 25, 2017
| * @return the port that the exposed port is mapped to | ||
| * @throws IllegalStateException if there are no exposed ports | ||
| */ | ||
| default Integer getFirstMappedPort() { |
Member
There was a problem hiding this comment.
🤔 is use of streams absolutely essential here? 😉
Member
Author
There was a problem hiding this comment.
Well, at least I wouldn't say it's a misuse :)
Also, I prefer findFirst + map over !isEmpty() + .get(0), less error prone if you ask me
Member
|
Seems a very good idea- as you say for most usages this is going to simplify usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the usage for 90% cases where users have something like:
by introducing new method:
and it is just a safer version of:
It helps to remove some boilerplate, as well as "magic number" duplication.