Fixing Pydantic Extension#1021
Merged
tfranzel merged 2 commits intotfranzel:masterfrom Jul 9, 2023
Merged
Conversation
tfranzel
reviewed
Jul 8, 2023
Owner
tfranzel
left a comment
There was a problem hiding this comment.
excellent point @sydney-runkle. it is the better implementation.
I totally forgot about #801 and reimplemented the extension. 🤣 I wonder though how he got the extension working without the 3 fixes we applied specifically for this to work.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 68 68
Lines 8338 8338
=======================================
Hits 8217 8217
Misses 121 121 ☔ View full report in Codecov by Sentry. |
Owner
|
excellent! thx sydney. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey tfranzel,
Thanks for your help with adding support for
pydantica few weeks ago.It came to my attention earlier today while running some tests that the
__schema_cache__frompydanticwas causing problems when any of the pages associated with the schema views were refreshed. Themodel_schemafunction frompydanticdoesn't use a cache, whereas themodel.schema()does utilize this cache. Additionally, theref_prefixparam of themodel_schemafunction allows for the removal of some of the other functionality we hard coded.I came up with the above solution based on the
pydanticdocumentation as well as this previously opened issue.Let me know what you think!