-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathstream_test.go
More file actions
1587 lines (1377 loc) · 43 KB
/
stream_test.go
File metadata and controls
1587 lines (1377 loc) · 43 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// stream_test.go contains tests for the streaming io.Reader/io.Writer API.
package gopus
import (
"bytes"
"encoding/binary"
"errors"
"io"
"math"
"testing"
)
// slicePacketSource implements PacketReader for testing.
type slicePacketSource struct {
packets [][]byte
index int
}
func (s *slicePacketSource) ReadPacketInto(dst []byte) (int, uint64, error) {
if s.index >= len(s.packets) {
return 0, 0, io.EOF
}
packet := s.packets[s.index]
s.index++
if packet == nil {
return 0, 0, nil
}
if len(packet) > len(dst) {
return 0, 0, ErrPacketTooLarge
}
n := copy(dst, packet)
return n, 0, nil
}
type slicePacketSourceWithGranule struct {
packets [][]byte
granules []uint64
index int
}
func (s *slicePacketSourceWithGranule) ReadPacketInto(dst []byte) (int, uint64, error) {
if s.index >= len(s.packets) {
return 0, 0, io.EOF
}
packet := s.packets[s.index]
granule := s.granules[s.index]
s.index++
if packet == nil {
return 0, granule, nil
}
if len(packet) > len(dst) {
return 0, 0, ErrPacketTooLarge
}
n := copy(dst, packet)
return n, granule, nil
}
// slicePacketSink implements PacketSink for testing.
type slicePacketSink struct {
packets [][]byte
}
func (s *slicePacketSink) WritePacket(packet []byte) (int, error) {
cp := make([]byte, len(packet))
copy(cp, packet)
s.packets = append(s.packets, cp)
return len(packet), nil
}
type closablePacketSink struct {
slicePacketSink
closeCalls int
}
func (s *closablePacketSink) Close() error {
s.closeCalls++
return nil
}
type scriptedPacketSink struct {
packets [][]byte
calls int
failAtCall int
shortBytes int
err error
}
func (s *scriptedPacketSink) WritePacket(packet []byte) (int, error) {
s.calls++
if s.calls == s.failAtCall {
if s.err != nil {
return s.shortBytes, s.err
}
return s.shortBytes, nil
}
cp := make([]byte, len(packet))
copy(cp, packet)
s.packets = append(s.packets, cp)
return len(packet), nil
}
// generateTestPacket generates a valid Opus packet by encoding test audio.
func generateTestPacket(sampleRate, channels, frameSize int) ([]byte, error) {
enc, err := NewEncoder(EncoderConfig{SampleRate: sampleRate, Channels: channels, Application: ApplicationAudio})
if err != nil {
return nil, err
}
enc.SetFrameSize(frameSize)
// Generate a simple sine wave
pcm := make([]float32, frameSize*channels)
freq := 440.0
for i := 0; i < frameSize; i++ {
sample := float32(0.5 * math.Sin(2*math.Pi*freq*float64(i)/float64(sampleRate)))
for ch := 0; ch < channels; ch++ {
pcm[i*channels+ch] = sample
}
}
return enc.EncodeFloat32(pcm)
}
// TestNewReader_ValidParams tests creating readers with valid parameters.
func TestNewReader_ValidParams(t *testing.T) {
testCases := []struct {
name string
sampleRate int
channels int
format SampleFormat
}{
{"48kHz mono float32", 48000, 1, FormatFloat32LE},
{"48kHz stereo float32", 48000, 2, FormatFloat32LE},
{"48kHz mono int16", 48000, 1, FormatInt16LE},
{"48kHz stereo int16", 48000, 2, FormatInt16LE},
{"24kHz mono float32", 24000, 1, FormatFloat32LE},
{"16kHz stereo int16", 16000, 2, FormatInt16LE},
{"8000Hz mono float32", 8000, 1, FormatFloat32LE},
{"12000Hz stereo int16", 12000, 2, FormatInt16LE},
}
source := &slicePacketSource{packets: nil}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
reader, err := NewReader(DefaultDecoderConfig(tc.sampleRate, tc.channels), source, tc.format)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
if reader.SampleRate() != tc.sampleRate {
t.Errorf("SampleRate() = %d, want %d", reader.SampleRate(), tc.sampleRate)
}
if reader.Channels() != tc.channels {
t.Errorf("Channels() = %d, want %d", reader.Channels(), tc.channels)
}
})
}
}
// TestNewReader_InvalidParams tests creating readers with invalid parameters.
func TestNewReader_InvalidParams(t *testing.T) {
source := &slicePacketSource{packets: nil}
testCases := []struct {
name string
sampleRate int
channels int
wantErr error
}{
{"invalid sample rate 44100", 44100, 1, ErrInvalidSampleRate},
{"invalid sample rate 0", 0, 1, ErrInvalidSampleRate},
{"invalid sample rate negative", -8000, 1, ErrInvalidSampleRate},
{"invalid channels 0", 48000, 0, ErrInvalidChannels},
{"invalid channels 3", 48000, 3, ErrInvalidChannels},
{"invalid channels negative", 48000, -1, ErrInvalidChannels},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
_, err := NewReader(DefaultDecoderConfig(tc.sampleRate, tc.channels), source, FormatFloat32LE)
if err != tc.wantErr {
t.Errorf("NewReader error = %v, want %v", err, tc.wantErr)
}
})
}
}
// TestReader_Read_SinglePacket tests reading from a single-packet source.
func TestReader_Read_SinglePacket(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960 // 20ms
packet, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
t.Logf("Generated packet: %d bytes", len(packet))
source := &slicePacketSource{packets: [][]byte{packet}}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read all data
var allBytes []byte
buf := make([]byte, 4096)
for {
n, err := reader.Read(buf)
if err == io.EOF {
break
}
if err != nil {
t.Fatalf("Read failed: %v", err)
}
allBytes = append(allBytes, buf[:n]...)
}
// Verify we got expected number of bytes
// frameSize * channels * 4 bytes per float32
expectedBytes := frameSize * channels * 4
t.Logf("Read %d bytes, expected %d", len(allBytes), expectedBytes)
if len(allBytes) < expectedBytes {
t.Errorf("Read %d bytes, want at least %d", len(allBytes), expectedBytes)
}
}
func TestReader_LastGranulePos(t *testing.T) {
packet, err := generateTestPacket(48000, 2, 960)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source := &slicePacketSourceWithGranule{
packets: [][]byte{packet},
granules: []uint64{960},
}
reader, err := NewReader(DefaultDecoderConfig(48000, 2), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
buf := make([]byte, 4096)
if _, err := reader.Read(buf); err != nil {
t.Fatalf("Read failed: %v", err)
}
if got := reader.LastGranulePos(); got != 960 {
t.Fatalf("LastGranulePos() = %d, want 960", got)
}
reader.Reset()
if got := reader.LastGranulePos(); got != 0 {
t.Fatalf("LastGranulePos() after Reset = %d, want 0", got)
}
}
// TestReader_Read_MultiplePackets tests reading across packet boundaries.
func TestReader_Read_MultiplePackets(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
// Generate 3 packets
packets := make([][]byte, 3)
for i := 0; i < 3; i++ {
packet, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
packets[i] = packet
}
source := &slicePacketSource{packets: packets}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read all data
var allBytes []byte
buf := make([]byte, 1000) // Small buffer to force multiple reads
for {
n, err := reader.Read(buf)
if err == io.EOF {
break
}
if err != nil {
t.Fatalf("Read failed: %v", err)
}
allBytes = append(allBytes, buf[:n]...)
}
// Each packet should produce frameSize * channels * 4 bytes
expectedBytesPerPacket := frameSize * channels * 4
expectedTotal := expectedBytesPerPacket * 3
t.Logf("Read %d bytes, expected %d", len(allBytes), expectedTotal)
if len(allBytes) < expectedTotal {
t.Errorf("Read %d bytes, want at least %d", len(allBytes), expectedTotal)
}
}
// TestReader_Read_PartialRead tests partial reads work correctly.
func TestReader_Read_PartialRead(t *testing.T) {
sampleRate := 48000
channels := 1
frameSize := 960
packet, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source := &slicePacketSource{packets: [][]byte{packet}}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read with very small buffer to force partial reads
var allBytes []byte
buf := make([]byte, 17) // Odd size that doesn't align with sample boundaries
for {
n, err := reader.Read(buf)
if err == io.EOF {
break
}
if err != nil {
t.Fatalf("Read failed: %v", err)
}
allBytes = append(allBytes, buf[:n]...)
}
// Verify all bytes read
expectedBytes := frameSize * channels * 4
t.Logf("Read %d bytes, expected %d", len(allBytes), expectedBytes)
if len(allBytes) < expectedBytes {
t.Errorf("Read %d bytes, want at least %d", len(allBytes), expectedBytes)
}
}
// TestReader_Read_EOF tests EOF handling.
func TestReader_Read_EOF(t *testing.T) {
source := &slicePacketSource{packets: [][]byte{}} // Empty source
reader, err := NewReader(DefaultDecoderConfig(48000, 2), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
buf := make([]byte, 4096)
n, err := reader.Read(buf)
if err != io.EOF {
t.Errorf("Read error = %v, want io.EOF", err)
}
if n != 0 {
t.Errorf("Read returned %d bytes on EOF, want 0", n)
}
// Second read should also return EOF
n, err = reader.Read(buf)
if err != io.EOF {
t.Errorf("Second Read error = %v, want io.EOF", err)
}
if n != 0 {
t.Errorf("Second Read returned %d bytes on EOF, want 0", n)
}
}
// TestReader_Read_PLC tests nil packet triggers PLC.
func TestReader_Read_PLC(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
// First packet is valid, second is nil (PLC), third is valid
packet1, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
packet3, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source := &slicePacketSource{packets: [][]byte{packet1, nil, packet3}}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read all data - should not error on nil packet
var allBytes []byte
buf := make([]byte, 4096)
for {
n, err := reader.Read(buf)
if err == io.EOF {
break
}
if err != nil {
t.Fatalf("Read failed: %v", err)
}
allBytes = append(allBytes, buf[:n]...)
}
// Should have 3 frames worth of data
expectedBytesPerFrame := frameSize * channels * 4
expectedTotal := expectedBytesPerFrame * 3
t.Logf("Read %d bytes, expected %d", len(allBytes), expectedTotal)
if len(allBytes) < expectedTotal {
t.Errorf("Read %d bytes, want at least %d", len(allBytes), expectedTotal)
}
}
// TestReader_Format_Float32LE tests float32 byte format.
func TestReader_Format_Float32LE(t *testing.T) {
sampleRate := 48000
channels := 1
frameSize := 960
packet, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source := &slicePacketSource{packets: [][]byte{packet}}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read all data
var allBytes []byte
buf := make([]byte, 4096)
for {
n, err := reader.Read(buf)
if err == io.EOF {
break
}
if err != nil {
t.Fatalf("Read failed: %v", err)
}
allBytes = append(allBytes, buf[:n]...)
}
// Parse bytes as float32 and verify they are valid
if len(allBytes)%4 != 0 {
t.Fatalf("Byte count %d not divisible by 4", len(allBytes))
}
numSamples := len(allBytes) / 4
for i := 0; i < numSamples; i++ {
bits := binary.LittleEndian.Uint32(allBytes[i*4:])
sample := math.Float32frombits(bits)
if math.IsNaN(float64(sample)) || math.IsInf(float64(sample), 0) {
t.Errorf("Invalid float32 at sample %d: %v", i, sample)
}
// Audio samples should be in [-1, 1] range (or slightly beyond due to processing)
if sample < -2.0 || sample > 2.0 {
t.Errorf("Sample %d out of range: %v", i, sample)
}
}
t.Logf("Verified %d float32 samples", numSamples)
}
// TestReader_Format_Int16LE tests int16 byte format.
func TestReader_Format_Int16LE(t *testing.T) {
sampleRate := 48000
channels := 1
frameSize := 960
packet, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source := &slicePacketSource{packets: [][]byte{packet}}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatInt16LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read all data
var allBytes []byte
buf := make([]byte, 4096)
for {
n, err := reader.Read(buf)
if err == io.EOF {
break
}
if err != nil {
t.Fatalf("Read failed: %v", err)
}
allBytes = append(allBytes, buf[:n]...)
}
// Parse bytes as int16 and verify they are valid
if len(allBytes)%2 != 0 {
t.Fatalf("Byte count %d not divisible by 2", len(allBytes))
}
numSamples := len(allBytes) / 2
var hasNonZero bool
var maxAbs int16
for i := 0; i < numSamples; i++ {
sample := int16(binary.LittleEndian.Uint16(allBytes[i*2:]))
if sample != 0 {
hasNonZero = true
}
if sample < 0 && -sample > maxAbs {
maxAbs = -sample
} else if sample > maxAbs {
maxAbs = sample
}
}
t.Logf("Verified %d int16 samples, maxAbs=%d, hasNonZero=%v", numSamples, maxAbs, hasNonZero)
// Note: Some codec processing may result in very low levels
// The primary check is that conversion happened correctly (divisible by 2, no crash)
}
// TestReader_Reset tests resetting the reader.
func TestReader_Reset(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
packet, err := generateTestPacket(sampleRate, channels, frameSize)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source := &slicePacketSource{packets: [][]byte{packet}}
reader, err := NewReader(DefaultDecoderConfig(sampleRate, channels), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Read some data
buf := make([]byte, 4096)
_, err = reader.Read(buf)
if err != nil && err != io.EOF {
t.Fatalf("Read failed: %v", err)
}
// Reset
reader.Reset()
// Verify state is cleared
if reader.offset != 0 {
t.Error("offset not reset")
}
if reader.eof {
t.Error("eof not reset")
}
if len(reader.byteBuf) != 0 {
t.Error("byteBuf not reset")
}
}
// TestSampleFormat_BytesPerSample tests BytesPerSample.
func TestSampleFormat_BytesPerSample(t *testing.T) {
testCases := []struct {
format SampleFormat
want int
}{
{FormatFloat32LE, 4},
{FormatInt16LE, 2},
{SampleFormat(999), 4}, // Unknown defaults to 4
}
for _, tc := range testCases {
got := tc.format.BytesPerSample()
if got != tc.want {
t.Errorf("SampleFormat(%d).BytesPerSample() = %d, want %d", tc.format, got, tc.want)
}
}
}
// TestReader_io_Reader_Interface verifies Reader implements io.Reader.
func TestReader_io_Reader_Interface(t *testing.T) {
source := &slicePacketSource{packets: nil}
reader, err := NewReader(DefaultDecoderConfig(48000, 2), source, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
// Verify interface compliance at compile time
var _ io.Reader = reader
// Also test with io.Copy
packet, err := generateTestPacket(48000, 2, 960)
if err != nil {
t.Fatalf("generateTestPacket failed: %v", err)
}
source2 := &slicePacketSource{packets: [][]byte{packet}}
reader2, err := NewReader(DefaultDecoderConfig(48000, 2), source2, FormatFloat32LE)
if err != nil {
t.Fatalf("NewReader failed: %v", err)
}
var buf bytes.Buffer
n, err := io.Copy(&buf, reader2)
if err != nil {
t.Fatalf("io.Copy failed: %v", err)
}
t.Logf("io.Copy copied %d bytes", n)
if n == 0 {
t.Error("io.Copy copied 0 bytes")
}
}
// generateFloat32Bytes generates float32 PCM bytes for a sine wave.
func generateFloat32Bytes(sampleRate, channels, numSamples int, freq float64) []byte {
buf := make([]byte, numSamples*channels*4)
for i := 0; i < numSamples; i++ {
sample := float32(0.5 * math.Sin(2*math.Pi*freq*float64(i)/float64(sampleRate)))
for ch := 0; ch < channels; ch++ {
idx := (i*channels + ch) * 4
bits := math.Float32bits(sample)
binary.LittleEndian.PutUint32(buf[idx:], bits)
}
}
return buf
}
// generateInt16Bytes generates int16 PCM bytes for a sine wave.
func generateInt16Bytes(sampleRate, channels, numSamples int, freq float64) []byte {
buf := make([]byte, numSamples*channels*2)
for i := 0; i < numSamples; i++ {
sample := int16(0.5 * 32767 * math.Sin(2*math.Pi*freq*float64(i)/float64(sampleRate)))
for ch := 0; ch < channels; ch++ {
idx := (i*channels + ch) * 2
binary.LittleEndian.PutUint16(buf[idx:], uint16(sample))
}
}
return buf
}
// TestNewWriter_ValidParams tests creating writers with valid parameters.
func TestNewWriter_ValidParams(t *testing.T) {
testCases := []struct {
name string
sampleRate int
channels int
format SampleFormat
app Application
}{
{"48kHz mono float32 audio", 48000, 1, FormatFloat32LE, ApplicationAudio},
{"48kHz stereo float32 audio", 48000, 2, FormatFloat32LE, ApplicationAudio},
{"48kHz mono int16 voip", 48000, 1, FormatInt16LE, ApplicationVoIP},
{"48kHz stereo int16 voip", 48000, 2, FormatInt16LE, ApplicationVoIP},
{"24kHz mono float32 lowdelay", 24000, 1, FormatFloat32LE, ApplicationLowDelay},
{"16kHz stereo int16 audio", 16000, 2, FormatInt16LE, ApplicationAudio},
}
sink := &slicePacketSink{}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
writer, err := NewWriter(tc.sampleRate, tc.channels, sink, tc.format, tc.app)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
if writer.SampleRate() != tc.sampleRate {
t.Errorf("SampleRate() = %d, want %d", writer.SampleRate(), tc.sampleRate)
}
if writer.Channels() != tc.channels {
t.Errorf("Channels() = %d, want %d", writer.Channels(), tc.channels)
}
})
}
}
// TestNewWriter_InvalidParams tests creating writers with invalid parameters.
func TestNewWriter_InvalidParams(t *testing.T) {
sink := &slicePacketSink{}
testCases := []struct {
name string
sampleRate int
channels int
wantErr error
}{
{"invalid sample rate 44100", 44100, 1, ErrInvalidSampleRate},
{"invalid sample rate 0", 0, 1, ErrInvalidSampleRate},
{"invalid channels 0", 48000, 0, ErrInvalidChannels},
{"invalid channels 3", 48000, 3, ErrInvalidChannels},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
_, err := NewWriter(tc.sampleRate, tc.channels, sink, FormatFloat32LE, ApplicationAudio)
if err != tc.wantErr {
t.Errorf("NewWriter error = %v, want %v", err, tc.wantErr)
}
})
}
}
// TestWriter_Write_SingleFrame tests writing exactly one frame.
func TestWriter_Write_SingleFrame(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
sink := &slicePacketSink{}
writer, err := NewWriter(sampleRate, channels, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
// Generate exactly one frame
pcmBytes := generateFloat32Bytes(sampleRate, channels, frameSize, 440.0)
n, err := writer.Write(pcmBytes)
if err != nil {
t.Fatalf("Write failed: %v", err)
}
if n != len(pcmBytes) {
t.Errorf("Write returned %d, want %d", n, len(pcmBytes))
}
// Should have one packet
if len(sink.packets) != 1 {
t.Errorf("Got %d packets, want 1", len(sink.packets))
}
t.Logf("Encoded %d bytes to %d byte packet", len(pcmBytes), len(sink.packets[0]))
}
// TestWriter_Write_MultipleFrames tests writing multiple frames at once.
func TestWriter_Write_MultipleFrames(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
numFrames := 3
sink := &slicePacketSink{}
writer, err := NewWriter(sampleRate, channels, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
// Generate three frames
pcmBytes := generateFloat32Bytes(sampleRate, channels, frameSize*numFrames, 440.0)
n, err := writer.Write(pcmBytes)
if err != nil {
t.Fatalf("Write failed: %v", err)
}
if n != len(pcmBytes) {
t.Errorf("Write returned %d, want %d", n, len(pcmBytes))
}
// Should have three packets
if len(sink.packets) != numFrames {
t.Errorf("Got %d packets, want %d", len(sink.packets), numFrames)
}
t.Logf("Encoded %d frames to %d packets", numFrames, len(sink.packets))
}
// TestWriter_Write_PartialFrame tests writing less than one frame (buffering).
func TestWriter_Write_PartialFrame(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
sink := &slicePacketSink{}
writer, err := NewWriter(sampleRate, channels, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
// Write half a frame
halfFrameSamples := frameSize / 2
pcmBytes := generateFloat32Bytes(sampleRate, channels, halfFrameSamples, 440.0)
n, err := writer.Write(pcmBytes)
if err != nil {
t.Fatalf("Write failed: %v", err)
}
if n != len(pcmBytes) {
t.Errorf("Write returned %d, want %d", n, len(pcmBytes))
}
// Should have no packets yet
if len(sink.packets) != 0 {
t.Errorf("Got %d packets, want 0 (should be buffered)", len(sink.packets))
}
// Write another half
n, err = writer.Write(pcmBytes)
if err != nil {
t.Fatalf("Second Write failed: %v", err)
}
if n != len(pcmBytes) {
t.Errorf("Second Write returned %d, want %d", n, len(pcmBytes))
}
// Now should have one packet
if len(sink.packets) != 1 {
t.Errorf("Got %d packets, want 1", len(sink.packets))
}
t.Logf("Buffering works: two half-frame writes produced 1 packet")
}
// TestWriter_Write_CrossFrameBoundary tests writing that spans frame boundaries.
func TestWriter_Write_CrossFrameBoundary(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
sink := &slicePacketSink{}
writer, err := NewWriter(sampleRate, channels, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
// Write 1.5 frames worth
samples := frameSize + frameSize/2
pcmBytes := generateFloat32Bytes(sampleRate, channels, samples, 440.0)
n, err := writer.Write(pcmBytes)
if err != nil {
t.Fatalf("Write failed: %v", err)
}
if n != len(pcmBytes) {
t.Errorf("Write returned %d, want %d", n, len(pcmBytes))
}
// Should have 1 packet, 0.5 frame buffered
if len(sink.packets) != 1 {
t.Errorf("Got %d packets, want 1", len(sink.packets))
}
// Write another 0.5 frame to complete the buffered data
pcmBytes2 := generateFloat32Bytes(sampleRate, channels, frameSize/2, 440.0)
_, err = writer.Write(pcmBytes2)
if err != nil {
t.Fatalf("Second Write failed: %v", err)
}
// Now should have 2 packets
if len(sink.packets) != 2 {
t.Errorf("Got %d packets, want 2", len(sink.packets))
}
t.Logf("Cross-boundary writes work: got %d packets", len(sink.packets))
}
// TestWriter_Flush tests flushing remaining buffered samples.
func TestWriter_Flush(t *testing.T) {
sampleRate := 48000
channels := 2
frameSize := 960
sink := &slicePacketSink{}
writer, err := NewWriter(sampleRate, channels, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
// Write partial frame
partialSamples := frameSize / 4
pcmBytes := generateFloat32Bytes(sampleRate, channels, partialSamples, 440.0)
_, err = writer.Write(pcmBytes)
if err != nil {
t.Fatalf("Write failed: %v", err)
}
// No packets yet
if len(sink.packets) != 0 {
t.Errorf("Got %d packets before flush, want 0", len(sink.packets))
}
// Flush
err = writer.Flush()
if err != nil {
t.Fatalf("Flush failed: %v", err)
}
// Now should have 1 packet (zero-padded)
if len(sink.packets) != 1 {
t.Errorf("Got %d packets after flush, want 1", len(sink.packets))
}
t.Logf("Flush zero-padded partial frame to packet of %d bytes", len(sink.packets[0]))
}
// TestWriter_Flush_Empty tests flushing with no buffered data.
func TestWriter_Flush_Empty(t *testing.T) {
sink := &slicePacketSink{}
writer, err := NewWriter(48000, 2, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
// Flush with nothing buffered should not error
err = writer.Flush()
if err != nil {
t.Fatalf("Flush failed: %v", err)
}
// No packets
if len(sink.packets) != 0 {
t.Errorf("Got %d packets from empty flush, want 0", len(sink.packets))
}
}
func TestWriter_Close_FlushesAndClosesSink(t *testing.T) {
sink := &closablePacketSink{}
writer, err := NewWriter(48000, 2, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
pcmBytes := generateFloat32Bytes(48000, 2, 960/2, 440.0)
if _, err := writer.Write(pcmBytes); err != nil {
t.Fatalf("Write failed: %v", err)
}
if err := writer.Close(); err != nil {
t.Fatalf("Close failed: %v", err)
}
if len(sink.packets) != 1 {
t.Fatalf("Close should flush one packet, got %d", len(sink.packets))
}
if sink.closeCalls != 1 {
t.Fatalf("Close should forward to sink once, got %d", sink.closeCalls)
}
}
func TestWriter_Close_Idempotent(t *testing.T) {
sink := &closablePacketSink{}
writer, err := NewWriter(48000, 2, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
if err := writer.Close(); err != nil {
t.Fatalf("first Close failed: %v", err)
}
if err := writer.Close(); err != nil {
t.Fatalf("second Close failed: %v", err)
}
if sink.closeCalls != 1 {
t.Fatalf("Close should be idempotent, got %d close calls", sink.closeCalls)
}
}
func TestWriter_WriteAfterClose(t *testing.T) {
sink := &slicePacketSink{}
writer, err := NewWriter(48000, 2, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
if err := writer.Close(); err != nil {
t.Fatalf("Close failed: %v", err)
}
if _, err := writer.Write([]byte{0, 1, 2, 3}); err != io.ErrClosedPipe {
t.Fatalf("Write after Close error = %v, want %v", err, io.ErrClosedPipe)
}
if err := writer.Flush(); err != io.ErrClosedPipe {
t.Fatalf("Flush after Close error = %v, want %v", err, io.ErrClosedPipe)
}
}
func TestWriter_ResetAfterCloseReopensWriter(t *testing.T) {
sink := &slicePacketSink{}
writer, err := NewWriter(48000, 2, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
if err := writer.Close(); err != nil {
t.Fatalf("Close failed: %v", err)
}
writer.Reset()
pcmBytes := generateFloat32Bytes(48000, 2, 960, 440.0)
if _, err := writer.Write(pcmBytes); err != nil {
t.Fatalf("Write after Reset failed: %v", err)
}
if len(sink.packets) != 1 {
t.Fatalf("Write after Reset produced %d packets, want 1", len(sink.packets))
}
}
func TestWriter_SinkShortWriteReturnsPartialProgress(t *testing.T) {
const (
sampleRate = 48000
channels = 2
frameSize = 960
)
sink := &scriptedPacketSink{failAtCall: 2, shortBytes: 1}
writer, err := NewWriter(sampleRate, channels, sink, FormatFloat32LE, ApplicationAudio)
if err != nil {
t.Fatalf("NewWriter failed: %v", err)
}
pcmBytes := generateFloat32Bytes(sampleRate, channels, frameSize*2, 440.0)
n, err := writer.Write(pcmBytes)
if err != io.ErrShortWrite {
t.Fatalf("Write error = %v, want %v", err, io.ErrShortWrite)