Skip to content

Commit d73065a

Browse files
sduskisthiyaguk09
sduskis
authored and
thiyaguk09
committed
Use assert.deepStrictEqual instead of deepEqual. (googleapis#253)
1 parent bb7cc3e commit d73065a

13 files changed

Lines changed: 206 additions & 156 deletions

File tree

‎handwritten/bigtable/system-test/bigtable.js‎

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ describe('Bigtable', function() {
423423
assert.ifError(err);
424424
assert.strictEqual(families.length, 3);
425425
assert(families[0] instanceof Family);
426-
assert.notEqual(
426+
assert.notStrictEqual(
427427
-1,
428428
families
429429
.map(f => {
@@ -554,7 +554,7 @@ describe('Bigtable', function() {
554554
assert.ifError(err);
555555
var maxAge = metadata.gcRule.maxAge;
556556

557-
assert.strictEqual(maxAge.seconds, rule.age.seconds);
557+
assert.strictEqual(maxAge.seconds, rule.age.seconds.toString());
558558
assert.strictEqual(maxAge.nanas, rule.age.nanas);
559559
done();
560560
});
@@ -942,7 +942,7 @@ describe('Bigtable', function() {
942942
})
943943
.sort();
944944

945-
assert.deepEqual(keys, ['alincoln', 'jadams', 'tjefferson']);
945+
assert.deepStrictEqual(keys, ['alincoln', 'jadams', 'tjefferson']);
946946

947947
done();
948948
});
@@ -1002,7 +1002,7 @@ describe('Bigtable', function() {
10021002
rows.forEach(function(row) {
10031003
var keys = Object.keys(row.data.follows).sort();
10041004

1005-
assert.deepEqual(keys, ['gwashington', 'jadams']);
1005+
assert.deepStrictEqual(keys, ['gwashington', 'jadams']);
10061006
});
10071007

10081008
done();
@@ -1087,7 +1087,7 @@ describe('Bigtable', function() {
10871087
assert(rows.length > 0);
10881088

10891089
var families = Object.keys(rows[0].data);
1090-
assert.deepEqual(families, ['traits']);
1090+
assert.deepStrictEqual(families, ['traits']);
10911091
done();
10921092
});
10931093
});
@@ -1121,7 +1121,7 @@ describe('Bigtable', function() {
11211121
})
11221122
.sort();
11231123

1124-
assert.deepEqual(ids, ['gwashington', 'tjefferson']);
1124+
assert.deepStrictEqual(ids, ['gwashington', 'tjefferson']);
11251125

11261126
done();
11271127
});
@@ -1140,7 +1140,7 @@ describe('Bigtable', function() {
11401140

11411141
Object.keys(follows).forEach(function(column) {
11421142
follows[column].forEach(function(cell) {
1143-
assert.deepEqual(cell.labels, [filter.label]);
1143+
assert.deepStrictEqual(cell.labels, [filter.label]);
11441144
});
11451145
});
11461146
});
@@ -1163,7 +1163,7 @@ describe('Bigtable', function() {
11631163
})
11641164
.sort();
11651165

1166-
assert.deepEqual(keys, ['gwashington', 'tjefferson']);
1166+
assert.deepStrictEqual(keys, ['gwashington', 'tjefferson']);
11671167

11681168
done();
11691169
});
@@ -1204,7 +1204,11 @@ describe('Bigtable', function() {
12041204

12051205
var columns = Object.keys(rows[0].data.follows).sort();
12061206

1207-
assert.deepEqual(columns, ['gwashington', 'jadams', 'tjefferson']);
1207+
assert.deepStrictEqual(columns, [
1208+
'gwashington',
1209+
'jadams',
1210+
'tjefferson',
1211+
]);
12081212

12091213
done();
12101214
});

‎handwritten/bigtable/system-test/mutate-rows.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe('Bigtable/Table', () => {
9292
responses = test.responses;
9393
TABLE.maxRetries = test.max_retries;
9494
TABLE.mutate(test.mutations_request, error => {
95-
assert.deepEqual(
95+
assert.deepStrictEqual(
9696
mutationBatchesInvoked,
9797
test.mutation_batches_invoked
9898
);
@@ -116,11 +116,11 @@ describe('Bigtable/Table', () => {
116116
const expectedIndices = test.errors.map(error => {
117117
return error.index_in_mutations_request;
118118
});
119-
assert.deepEqual(error.name, 'PartialFailureError');
119+
assert.deepStrictEqual(error.name, 'PartialFailureError');
120120
const actualIndices = error.errors.map(error => {
121121
return test.mutations_request.indexOf(error.entry);
122122
});
123-
assert.deepEqual(expectedIndices, actualIndices);
123+
assert.deepStrictEqual(expectedIndices, actualIndices);
124124
} else {
125125
assert.ifError(error);
126126
}

‎handwritten/bigtable/system-test/read-rows-acceptance-tests.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ describe('Read Row Acceptance tests', function() {
128128
function verify() {
129129
assert.strictEqual(errors.length, errorCount, ' error count mismatch');
130130
assert.strictEqual(rows.length, results.length, 'row count mismatch');
131-
assert.deepEqual(rows, tableRows, 'row mismatch');
131+
assert.deepStrictEqual(rows, tableRows, 'row mismatch');
132132
done();
133133
}
134134
});

‎handwritten/bigtable/test/app-profile.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ describe('Bigtable/AppProfile', function() {
182182
assert.strictEqual(config.client, 'BigtableInstanceAdminClient');
183183
assert.strictEqual(config.method, 'deleteAppProfile');
184184

185-
assert.deepEqual(config.reqOpts, {
185+
assert.deepStrictEqual(config.reqOpts, {
186186
name: appProfile.name,
187187
});
188188

@@ -290,7 +290,7 @@ describe('Bigtable/AppProfile', function() {
290290

291291
it('should not require gaxOptions', function(done) {
292292
appProfile.getMetadata = function(gaxOptions) {
293-
assert.deepEqual(gaxOptions, {});
293+
assert.deepStrictEqual(gaxOptions, {});
294294
done();
295295
};
296296

@@ -332,11 +332,11 @@ describe('Bigtable/AppProfile', function() {
332332
assert.strictEqual(config.client, 'BigtableInstanceAdminClient');
333333
assert.strictEqual(config.method, 'getAppProfile');
334334

335-
assert.deepEqual(config.reqOpts, {
335+
assert.deepStrictEqual(config.reqOpts, {
336336
name: appProfile.name,
337337
});
338338

339-
assert.deepEqual(config.gaxOpts, {});
339+
assert.deepStrictEqual(config.gaxOpts, {});
340340

341341
done();
342342
};

‎handwritten/bigtable/test/chunktransformer.js‎

Lines changed: 67 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -66,20 +66,28 @@ describe('Bigtable/ChunkTransformer', function() {
6666
this.qualifier = {};
6767
this.row = {};
6868
this.state = RowStateEnum.NEW_ROW;
69-
assert.deepEqual(chunkTransformer.row, {}, 'invalid initial state');
70-
assert.deepEqual(
69+
assert.deepStrictEqual(chunkTransformer.row, {}, 'invalid initial state');
70+
assert.deepStrictEqual(
7171
chunkTransformer.prevRowKey,
7272
null,
7373
'invalid initial state'
7474
);
75-
assert.deepEqual(chunkTransformer.family, {}, 'invalid initial state');
76-
assert.deepEqual(
75+
assert.deepStrictEqual(
76+
chunkTransformer.family,
77+
{},
78+
'invalid initial state'
79+
);
80+
assert.deepStrictEqual(
7781
chunkTransformer.qualifiers,
7882
[],
7983
'invalid initial state'
8084
);
81-
assert.deepEqual(chunkTransformer.qualifier, {}, 'invalid initial state');
82-
assert.deepEqual(
85+
assert.deepStrictEqual(
86+
chunkTransformer.qualifier,
87+
{},
88+
'invalid initial state'
89+
);
90+
assert.deepStrictEqual(
8391
chunkTransformer.state,
8492
RowStateEnum.NEW_ROW,
8593
'invalid initial state'
@@ -204,7 +212,7 @@ describe('Bigtable/ChunkTransformer', function() {
204212
},
205213
},
206214
};
207-
assert.deepEqual(rows[0], expectedRow);
215+
assert.deepStrictEqual(rows[0], expectedRow);
208216
});
209217
it('partial row ', function() {
210218
const chunk = {
@@ -235,7 +243,7 @@ describe('Bigtable/ChunkTransformer', function() {
235243
},
236244
},
237245
};
238-
assert.deepEqual(chunkTransformer.row, partialRow);
246+
assert.deepStrictEqual(chunkTransformer.row, partialRow);
239247
assert.strictEqual(
240248
chunkTransformer.state,
241249
RowStateEnum.ROW_IN_PROGRESS,
@@ -271,7 +279,7 @@ describe('Bigtable/ChunkTransformer', function() {
271279
},
272280
},
273281
};
274-
assert.deepEqual(chunkTransformer.row, partialRow);
282+
assert.deepStrictEqual(chunkTransformer.row, partialRow);
275283
assert.strictEqual(
276284
chunkTransformer.state,
277285
RowStateEnum.CELL_IN_PROGRESS,
@@ -407,7 +415,7 @@ describe('Bigtable/ChunkTransformer', function() {
407415
},
408416
};
409417
const row = rows[0];
410-
assert.deepEqual(row, expectedRow, 'row mismatch');
418+
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
411419
assert.strictEqual(
412420
chunkTransformer.state,
413421
RowStateEnum.NEW_ROW,
@@ -453,7 +461,7 @@ describe('Bigtable/ChunkTransformer', function() {
453461
},
454462
};
455463
const row = rows[0];
456-
assert.deepEqual(row, expectedRow, 'row mismatch');
464+
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
457465
assert.strictEqual(
458466
chunkTransformer.state,
459467
RowStateEnum.NEW_ROW,
@@ -502,7 +510,7 @@ describe('Bigtable/ChunkTransformer', function() {
502510
},
503511
};
504512
const row = rows[0];
505-
assert.deepEqual(row, expectedRow, 'row mismatch');
513+
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
506514
assert.strictEqual(
507515
chunkTransformer.state,
508516
RowStateEnum.NEW_ROW,
@@ -544,7 +552,7 @@ describe('Bigtable/ChunkTransformer', function() {
544552
},
545553
},
546554
};
547-
assert.deepEqual(
555+
assert.deepStrictEqual(
548556
chunkTransformer.row,
549557
expectedState,
550558
'row state mismatch'
@@ -596,7 +604,11 @@ describe('Bigtable/ChunkTransformer', function() {
596604
},
597605
},
598606
};
599-
assert.deepEqual(chunkTransformer.row, expectedState, 'row mismatch');
607+
assert.deepStrictEqual(
608+
chunkTransformer.row,
609+
expectedState,
610+
'row mismatch'
611+
);
600612
assert.strictEqual(
601613
chunkTransformer.state,
602614
RowStateEnum.ROW_IN_PROGRESS,
@@ -727,7 +739,7 @@ describe('Bigtable/ChunkTransformer', function() {
727739
},
728740
};
729741
const row = rows[0];
730-
assert.deepEqual(row, expectedRow, 'row mismatch');
742+
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
731743
assert.strictEqual(
732744
chunkTransformer.state,
733745
RowStateEnum.NEW_ROW,
@@ -775,7 +787,11 @@ describe('Bigtable/ChunkTransformer', function() {
775787
},
776788
},
777789
};
778-
assert.deepEqual(chunkTransformer.row, expectedState, 'row mismatch');
790+
assert.deepStrictEqual(
791+
chunkTransformer.row,
792+
expectedState,
793+
'row mismatch'
794+
);
779795
assert.strictEqual(
780796
chunkTransformer.state,
781797
RowStateEnum.ROW_IN_PROGRESS,
@@ -834,7 +850,11 @@ describe('Bigtable/ChunkTransformer', function() {
834850
},
835851
},
836852
};
837-
assert.deepEqual(chunkTransformer.row, expectedState, 'row mismatch');
853+
assert.deepStrictEqual(
854+
chunkTransformer.row,
855+
expectedState,
856+
'row mismatch'
857+
);
838858
assert.strictEqual(
839859
chunkTransformer.state,
840860
RowStateEnum.ROW_IN_PROGRESS,
@@ -938,7 +958,7 @@ describe('Bigtable/ChunkTransformer', function() {
938958
{},
939959
callback
940960
);
941-
assert.deepEqual(chunkTransformer.lastRowKey, 'foo');
961+
assert.deepStrictEqual(chunkTransformer.lastRowKey, 'foo');
942962
});
943963
});
944964
describe('reset', function() {
@@ -962,20 +982,28 @@ describe('Bigtable/ChunkTransformer', function() {
962982
};
963983
this.state = RowStateEnum.CELL_IN_PROGRESS;
964984
chunkTransformer.reset();
965-
assert.deepEqual(chunkTransformer.row, {}, 'invalid initial state');
966-
assert.deepEqual(
985+
assert.deepStrictEqual(chunkTransformer.row, {}, 'invalid initial state');
986+
assert.deepStrictEqual(
967987
chunkTransformer.prevRowKey,
968988
null,
969989
'invalid initial state'
970990
);
971-
assert.deepEqual(chunkTransformer.family, {}, 'invalid initial state');
972-
assert.deepEqual(
991+
assert.deepStrictEqual(
992+
chunkTransformer.family,
993+
{},
994+
'invalid initial state'
995+
);
996+
assert.deepStrictEqual(
973997
chunkTransformer.qualifiers,
974998
[],
975999
'invalid initial state'
9761000
);
977-
assert.deepEqual(chunkTransformer.qualifier, {}, 'invalid initial state');
978-
assert.deepEqual(
1001+
assert.deepStrictEqual(
1002+
chunkTransformer.qualifier,
1003+
{},
1004+
'invalid initial state'
1005+
);
1006+
assert.deepStrictEqual(
9791007
chunkTransformer.state,
9801008
RowStateEnum.NEW_ROW,
9811009
'invalid initial state'
@@ -1008,20 +1036,28 @@ describe('Bigtable/ChunkTransformer', function() {
10081036
this.state = RowStateEnum.CELL_IN_PROGRESS;
10091037
chunkTransformer.commit();
10101038
assert(resetSpy.called, 'did not call reset');
1011-
assert.deepEqual(chunkTransformer.row, {}, 'invalid initial state');
1012-
assert.deepEqual(
1039+
assert.deepStrictEqual(chunkTransformer.row, {}, 'invalid initial state');
1040+
assert.deepStrictEqual(
10131041
chunkTransformer.prevRowKey,
10141042
'key',
10151043
'invalid initial state'
10161044
);
1017-
assert.deepEqual(chunkTransformer.family, {}, 'invalid initial state');
1018-
assert.deepEqual(
1045+
assert.deepStrictEqual(
1046+
chunkTransformer.family,
1047+
{},
1048+
'invalid initial state'
1049+
);
1050+
assert.deepStrictEqual(
10191051
chunkTransformer.qualifiers,
10201052
[],
10211053
'invalid initial state'
10221054
);
1023-
assert.deepEqual(chunkTransformer.qualifier, {}, 'invalid initial state');
1024-
assert.deepEqual(
1055+
assert.deepStrictEqual(
1056+
chunkTransformer.qualifier,
1057+
{},
1058+
'invalid initial state'
1059+
);
1060+
assert.deepStrictEqual(
10251061
chunkTransformer.state,
10261062
RowStateEnum.NEW_ROW,
10271063
'invalid initial state'
@@ -1072,7 +1108,7 @@ describe('Bigtable/ChunkTransformer', function() {
10721108
},
10731109
};
10741110
const row = rows[0];
1075-
assert.deepEqual(row, expectedRow, 'row mismatch');
1111+
assert.deepStrictEqual(row, expectedRow, 'row mismatch');
10761112
assert.strictEqual(
10771113
chunkTransformer.state,
10781114
RowStateEnum.NEW_ROW,

0 commit comments

Comments
 (0)
⚡