Skip to content

Escape key of alias to support using $ prefix#313

Merged
fatfisz merged 2 commits intotleunen:masterfrom
Telokis:master
Aug 23, 2018
Merged

Escape key of alias to support using $ prefix#313
fatfisz merged 2 commits intotleunen:masterfrom
Telokis:master

Conversation

@Telokis
Copy link
Copy Markdown
Contributor

@Telokis Telokis commented Aug 18, 2018

Closes #312

(See #312 for detailed explanation)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2018

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️

Copy link
Copy Markdown
Contributor

@fatfisz fatfisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, LGTM!

@fatfisz fatfisz merged commit 4c56684 into tleunen:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants