Skip to content

Commit bdf505b

Browse files
committed
win,msi: highlight installation of 3rd-party tools
Currently, the installation wizard more or less silently installs third-party software (Boxstarter + Chocolatey). This adds some text to the MSI installation dialog and to the Boxstarter installation script. Refs: nodejs#22645 Refs: nodejs#22988
1 parent 0dbc8c8 commit bdf505b

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

tools/msvs/install_tools/install_tools.bat

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ echo Tools for Node.js Native Modules Installation Script
55
echo ====================================================
66
echo.
77
echo This Boxstarter script will install Python and the Visual Studio Build Tools,
8-
echo necessary to compile Node.js native modules. All necessary Windows updates
9-
echo will also be installed.
8+
echo necessary to compile Node.js native modules. Note that Boxstarter,
9+
echo Chocolatey and required Windows updates will also be installed.
1010
echo.
1111
echo This will require about 3 Gb of free disk space, plus any space necessary to
1212
echo install Windows updates.

tools/msvs/msi/i18n/en-us.wxl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<String Id="NativeToolsDlgBannerBitmap">WixUI_Bmp_Banner</String>
1515
<String Id="NativeToolsDlgIntro">Some npm modules need to be compiled from C/C++ when installing. If you want to be able to install such modules, some tools (Python 2 and Visual Studio Build Tools) need to be installed.</String>
1616
<String Id="NativeToolsDlgInstallCheckbox">Automatically install the necessary tools. The script will pop-up in a new window after the installation completes.</String>
17-
<String Id="NativeToolsDlgManualDetails">Alternatively, follow the instructions at <![CDATA[<a href="https://github.com/nodejs/node-gyp#on-windows">https://github.com/nodejs/node-gyp#on-windows</a>]]> to install the dependencies yourself.</String>
17+
<String Id="NativeToolsDlgManualDetails">Note that this will also install Boxstarter and Chocolatey. Alternatively, follow the instructions at <![CDATA[<a href="https://github.com/nodejs/node-gyp#on-windows">https://github.com/nodejs/node-gyp#on-windows</a>]]> to install the dependencies yourself.</String>
1818

1919
<!-- References like [ProductName] or $(var.ProductName) don't seem to work in Title attributes -->
2020
<String Id="NodeRuntime_Title">Node.js runtime</String>

0 commit comments

Comments
 (0)