Making isIgnored public jenkinsci/violation-comments-to-stash-plugin#72

Author: tomasbjerre

build.gradle

@@ -19,7 +19,7 @@ apply from: project.buildscript.classLoader.getResource('release.gradle').toURI(
 
 
 dependencies {
- compile 'se.bjurr.violations:violation-comments-lib:1.102'
+ compile 'se.bjurr.violations:violation-comments-lib:1.104'
  compile 'com.jayway.jsonpath:json-path:2.0.0'
  compile 'com.google.code.gson:gson:2.8.0'
  compile 'com.google.guava:guava:20.0'

src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/BitbucketServerCommentsProvider.java

@@ -4,6 +4,7 @@
 import static com.google.common.cache.CacheBuilder.newBuilder;
 import static com.google.common.collect.Lists.newArrayList;
 import static java.util.concurrent.TimeUnit.MINUTES;
+import static java.util.logging.Level.INFO;
 import static java.util.logging.Level.SEVERE;
 import static se.bjurr.violations.comments.bitbucketserver.lib.client.model.DIFFTYPE.ADDED;
 
@@ -32,6 +33,7 @@
 import se.bjurr.violations.comments.lib.model.ChangedFile;
 import se.bjurr.violations.comments.lib.model.Comment;
 import se.bjurr.violations.lib.ViolationsLogger;
+import se.bjurr.violations.lib.reports.ReportsFinder;
 
 public class BitbucketServerCommentsProvider implements CommentsProvider {
   private static final Integer BITBUCKET_MAX_COMMENT_SIZE = 32767;
@@ -121,6 +123,16 @@ public List<Comment> getComments() {
        * This is time consuming to do and is only needed if we are creating comments on each file.
        */
       for (final String changedFile : this.client.pullRequestChanges()) {
+        final List<String> ignorePaths = this.violationCommentsToBitbucketApi.getIgnorePaths();
+        if (ReportsFinder.isIgnored(changedFile, ignorePaths)) {
+          this.violationsLogger.log(
+              INFO,
+              "Ignoring changed file "
+                  + changedFile
+                  + " because it matched ignored paths: "
+                  + ignorePaths);
+          continue;
+        }
         final List<BitbucketServerComment> bitbucketServerCommentsOnFile =
             this.client.pullRequestComments(changedFile);
         for (final BitbucketServerComment fileComment : bitbucketServerCommentsOnFile) {

src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/ViolationCommentsToBitbucketServerApi.java

@@ -7,6 +7,7 @@
 import static se.bjurr.violations.lib.util.Utils.firstNonNull;
 import static se.bjurr.violations.lib.util.Utils.isNullOrEmpty;
 
+import java.util.List;
 import java.util.Optional;
 import java.util.Set;
 import java.util.logging.Level;
@@ -67,6 +68,7 @@ public void log(final Level level, final String string, final Throwable t) {
           });
   private Integer maxNumberOfViolations;
   private boolean shouldCommentOnlyChangedFiles = true;
+  private List<String> ignorePaths;
 
   private ViolationCommentsToBitbucketServerApi() {}
 
@@ -393,4 +395,13 @@ public ViolationCommentsToBitbucketServerApi withMaxNumberOfViolations(
   public Integer getMaxNumberOfViolations() {
     return this.maxNumberOfViolations;
   }
+
+  public List<String> getIgnorePaths() {
+    return this.ignorePaths;
+  }
+
+  public ViolationCommentsToBitbucketServerApi withIgnorePaths(final List<String> ignorePaths) {
+    this.ignorePaths = ignorePaths;
+    return this;
+  }
 }

src/test/java/se/bjurr/violations/comments/bitbucketserver/lib/client/BitbucketServerIntegrationTest.java

@@ -82,7 +82,7 @@ public void withCreateCommentWithAllSingleFileComments() throws Exception {
     violations.add(
         violationBuilder() //
             .setFile(CHANGED_FILE) //
-            .setMessage("no not ok!") //
+            .setMessage("no not ok!\nnewline") //
             .setSeverity(SEVERITY.ERROR) //
             .setStartLine(12) //
             .setReporter("The tool") //