Using UTF-8 in Bitbucket client JENKINS-48648

Author: tomasbjerre

.gitignore

@@ -7,3 +7,4 @@ target
 bin
 temp
 .gradle
+.okhttpcache

CHANGELOG.md

@@ -1,5 +1,58 @@
 
-# Changelog
+ # Violation comments to bitbucket server lib changelog
+
+Changelog of Violation comments to bitbucket server lib.
+
+## Unreleased
+### Jira JENKINS-48648 
+
+**Using UTF-8 in Bitbucket client**
+
+
+[34c3dfeaa82a055](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/34c3dfeaa82a055) Tomas Bjerre *2017-12-20 20:16:59*
+
+
+## 1.34
+### No issue
+
+**Refactoring build scripts**
+
+
+[5bf64160d6ca74c](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/5bf64160d6ca74c) Tomas Bjerre *2017-12-07 16:01:06*
+
+
+## 1.33
+### No issue
+
+**Resharper WikiUrl**
+
+
+[c08ea355348f350](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/c08ea355348f350) Tomas Bjerre *2017-10-13 09:40:16*
+
+
+## 1.32
+### No issue
+
+**Added handling for empty IssueType Description attributes for Resharper**
+
+
+[1e2311c342cf1e0](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/1e2311c342cf1e0) Tomas Bjerre *2017-10-09 16:37:54*
+
+**Doc**
+
+
+[37eeea9ff213c8a](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/37eeea9ff213c8a) Tomas Bjerre *2017-09-02 20:08:21*
+
+
+## 1.31
+### No issue
+
+**Google Java Format**
+
+
+[ff4e27423a411f7](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/ff4e27423a411f7) Tomas Bjerre *2017-09-02 11:50:15*
+
+
 ## 1.30
 ### No issue
 
@@ -22,9 +75,9 @@
 
 
 ## 1.28
-### No issue
+### GitHub [#2](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/issues/2) Paths with spaces fail
 
-**URL encoding paths #2**
+**URL encoding paths**
 
 
 [7122da4322e2f6e](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/7122da4322e2f6e) Tomas Bjerre *2017-08-02 15:29:50*
@@ -126,14 +179,17 @@
 
 
 ## 1.17
-### No issue
+### GitHub [#1](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/issues/1) NullPointerException when running the Jenkins plugin
 
-**Handling deleted files in PR:s #1**
+**Handling deleted files in PR:s**
 
  * And using violations lib 1.22 
 
 [40c69f6a7b64eea](https://github.com/tomasbjerre/violation-comments-to-bitbucket-server-lib/commit/40c69f6a7b64eea) Tomas Bjerre *2016-12-21 17:16:48*
 
+
+### No issue
+
 **violations lib 1.22**
 
 

build.gradle

@@ -27,4 +27,4 @@ dependencies {
  testCompile 'junit:junit:4.12'
  testCompile 'org.assertj:assertj-core:2.3.0'
  testCompile ('org.assertj:assertj-core:2.5.0')
-}
+}

build.sh

@@ -1,2 +1,2 @@
 #!/bin/bash
-./gradlew clean gitChangelogTask eclipse build install -i
+./gradlew --refresh-dependencies clean gitChangelogTask eclipse build install -i

src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/client/BitbucketServerInvoker.java

@@ -1,5 +1,6 @@
 package se.bjurr.violations.comments.bitbucketserver.lib.client;
 
+import static com.google.common.base.Charsets.UTF_8;
 import static com.google.common.base.Strings.isNullOrEmpty;
 
 import com.google.common.base.Throwables;
@@ -34,11 +35,12 @@ public String invokeUrl(
     try {
       CookieHandler.setDefault(new CookieManager(null, CookiePolicy.ACCEPT_ALL));
       conn = (HttpURLConnection) new URL(url).openConnection();
-      String userAndPass = bitbucketServerUser + ":" + bitbucketServerPassword;
-      String authString = new String(DatatypeConverter.printBase64Binary(userAndPass.getBytes()));
+      final String userAndPass = bitbucketServerUser + ":" + bitbucketServerPassword;
+      final String authString =
+          new String(DatatypeConverter.printBase64Binary(userAndPass.getBytes()));
       conn.setRequestProperty("Authorization", "Basic " + authString);
       conn.setRequestMethod(method.name());
-      String charset = "UTF-8";
+      final String charset = "UTF-8";
       conn.setDoOutput(true);
       conn.setRequestProperty("X-Atlassian-Token", "no-check");
       conn.setRequestProperty("Content-Type", "application/json");
@@ -48,15 +50,15 @@ public String invokeUrl(
         output = conn.getOutputStream();
         output.write(postContent.getBytes(charset));
       }
-      reader = new BufferedReader(new InputStreamReader(conn.getInputStream()));
-      StringBuilder stringBuilder = new StringBuilder();
+      reader = new BufferedReader(new InputStreamReader(conn.getInputStream(), UTF_8));
+      final StringBuilder stringBuilder = new StringBuilder();
       String line = null;
       while ((line = reader.readLine()) != null) {
         stringBuilder.append(line + "\n");
       }
-      String json = stringBuilder.toString();
+      final String json = stringBuilder.toString();
       return json;
-    } catch (Exception e) {
+    } catch (final Exception e) {
       throw new RuntimeException("Error calling:\n" + url + "\n" + method + "\n" + postContent, e);
     } finally {
       try {
@@ -69,7 +71,7 @@ public String invokeUrl(
         if (output != null) {
           output.close();
         }
-      } catch (IOException e) {
+      } catch (final IOException e) {
         throw Throwables.propagate(e);
       }
     }