Skip to content

Commit 5297e64

Browse files
committed
maxNumberOfComments
1 parent 428437e commit 5297e64

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ apply from: project.buildscript.classLoader.getResource('release.gradle').toURI(
1919

2020

2121
dependencies {
22-
compile 'se.bjurr.violations:violation-comments-lib:1.92'
22+
compile 'se.bjurr.violations:violation-comments-lib:1.93'
2323
compile 'com.jayway.jsonpath:json-path:2.0.0'
2424
compile 'com.google.code.gson:gson:2.8.0'
2525
compile 'com.google.guava:guava:20.0'

src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/BitbucketServerCommentsProvider.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,18 @@
77
import static java.util.logging.Level.SEVERE;
88
import static se.bjurr.violations.comments.bitbucketserver.lib.client.model.DIFFTYPE.ADDED;
99

10-
import com.google.common.annotations.VisibleForTesting;
11-
import com.google.common.cache.CacheLoader;
12-
import com.google.common.cache.LoadingCache;
1310
import java.util.ArrayDeque;
1411
import java.util.ArrayList;
1512
import java.util.Collection;
1613
import java.util.Deque;
1714
import java.util.Iterator;
1815
import java.util.List;
1916
import java.util.Optional;
17+
18+
import com.google.common.annotations.VisibleForTesting;
19+
import com.google.common.cache.CacheLoader;
20+
import com.google.common.cache.LoadingCache;
21+
2022
import se.bjurr.violations.comments.bitbucketserver.lib.client.BitbucketServerClient;
2123
import se.bjurr.violations.comments.bitbucketserver.lib.client.model.BitbucketServerComment;
2224
import se.bjurr.violations.comments.bitbucketserver.lib.client.model.BitbucketServerDiff;
@@ -32,6 +34,7 @@
3234
import se.bjurr.violations.comments.lib.model.Comment;
3335

3436
public class BitbucketServerCommentsProvider implements CommentsProvider {
37+
private static final Integer BITBUCKET_MAX_COMMENT_SIZE = 32767;
3538

3639
private final BitbucketServerClient client;
3740

@@ -267,7 +270,7 @@ private void removeTasks(final BitbucketServerComment comment) {
267270

268271
@Override
269272
public Integer getMaxNumberOfComments() {
270-
return violationCommentsToBitbucketApi.getMaxNumberOfComments();
273+
return BITBUCKET_MAX_COMMENT_SIZE;
271274
}
272275

273276
@Override

src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/ViolationCommentsToBitbucketServerApi.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
import java.util.Optional;
1111
import java.util.logging.Level;
1212
import java.util.logging.Logger;
13+
1314
import se.bjurr.violations.comments.lib.CommentsProvider;
1415
import se.bjurr.violations.comments.lib.ViolationsLogger;
1516
import se.bjurr.violations.lib.model.Violation;
1617

1718
public class ViolationCommentsToBitbucketServerApi {
18-
private static final Integer BITBUCKET_MAX_COMMENT_SIZE = 32767;
1919
public static final String DEFAULT_PROP_VIOLATIONS_PASSWORD = "VIOLATIONS_PASSWORD";
2020
public static final String DEFAULT_PROP_VIOLATIONS_USERNAME = "VIOLATIONS_USERNAME";
2121
public static final String DEFAULT_PROP_PERSONAL_ACCESS_TOKEN = "VIOLATIONS_PAT";
@@ -190,7 +190,7 @@ public void toPullRequest() throws Exception {
190190
checkState();
191191
final CommentsProvider commentsProvider =
192192
new BitbucketServerCommentsProvider(this, violationsLogger);
193-
createComments(violationsLogger, violations, BITBUCKET_MAX_COMMENT_SIZE, commentsProvider);
193+
createComments(violationsLogger, violations, commentsProvider);
194194
}
195195

196196
public ViolationCommentsToBitbucketServerApi withBitbucketServerUrl(

0 commit comments

Comments
 (0)