Markdown in comments and not commenting unchanged files

Author: tomasbjerre

build.gradle

@@ -63,7 +63,7 @@ repositories {
 }
 
 dependencies {
- compile 'se.bjurr.violations:violation-comments-lib:1.16'
+ compile 'se.bjurr.violations:violation-comments-lib:1.17'
  compile 'com.jayway.jsonpath:json-path:2.0.0'
 
  testCompile 'junit:junit:4.12'

src/main/java/se/bjurr/violations/comments/bitbucketserver/lib/ViolationCommentsToBitbucketServerApi.java

@@ -10,6 +10,7 @@
 import se.bjurr.violations.lib.model.Violation;
 
 public class ViolationCommentsToBitbucketServerApi {
+ private static final Integer BITBUCKET_MAX_COMMENT_SIZE = 32767;
  public static final String DEFAULT_PROP_VIOLATIONS_PASSWORD = "VIOLATIONS_PASSWORD";
  public static final String DEFAULT_PROP_VIOLATIONS_USERNAME = "VIOLATIONS_USERNAME";
 
@@ -33,51 +34,73 @@ private ViolationCommentsToBitbucketServerApi() {
 
  }
 
+ private void checkState() {
+  if (username == null || password == null) {
+   throw new IllegalStateException(
+     "User and Password must be set! They can be set with the API or by setting properties.\n" + //
+       "Username/password:\n" + //
+       "-D" + DEFAULT_PROP_VIOLATIONS_USERNAME + "=theuser -D" + DEFAULT_PROP_VIOLATIONS_PASSWORD + "=thepassword");
+  }
+  checkNotNull(bitbucketServerUrl, "BitbucketServerURL");
+  checkNotNull(pullRequestId, "PullRequestId");
+  checkNotNull(repoSlug, "repoSlug");
+  checkNotNull(projectKey, "projectKey");
+ }
+
  public String getBitbucketServerUrl() {
-  return this.bitbucketServerUrl;
+  return bitbucketServerUrl;
  }
 
  public boolean getCreateCommentWithAllSingleFileComments() {
-  return this.createCommentWithAllSingleFileComments;
+  return createCommentWithAllSingleFileComments;
  }
 
  public boolean getCreateSingleFileComments() {
-  return this.createSingleFileComments;
+  return createSingleFileComments;
  }
 
  public String getPassword() {
-  return this.password;
+  return password;
  }
 
  public String getProjectKey() {
-  return this.projectKey;
+  return projectKey;
  }
 
  public String getPropPassword() {
-  return this.propPassword;
+  return propPassword;
  }
 
  public String getPropUsername() {
-  return this.propUsername;
+  return propUsername;
  }
 
  public int getPullRequestId() {
-  return this.pullRequestId;
+  return pullRequestId;
  }
 
  public String getRepoSlug() {
-  return this.repoSlug;
+  return repoSlug;
  }
 
  public String getUsername() {
-  return this.username;
+  return username;
+ }
+
+ private void populateFromEnvironmentVariables() {
+  if (System.getProperty(propUsername) != null) {
+   username = firstNonNull(username, System.getProperty(propUsername));
+  }
+  if (System.getProperty(propPassword) != null) {
+   password = firstNonNull(password, System.getProperty(propPassword));
+  }
  }
 
  public void toPullRequest() throws Exception {
   populateFromEnvironmentVariables();
   checkState();
   CommentsProvider commentsProvider = new BitbucketServerCommentsProvider(this);
-  createComments(commentsProvider, this.violations);
+  createComments(commentsProvider, violations, BITBUCKET_MAX_COMMENT_SIZE);
  }
 
  public ViolationCommentsToBitbucketServerApi withBitbucketServerUrl(String bitbucketServerUrl) {
@@ -107,11 +130,11 @@ public ViolationCommentsToBitbucketServerApi withProjectKey(String projectKey) {
  }
 
  public void withPropPassword(String envPassword) {
-  this.propPassword = envPassword;
+  propPassword = envPassword;
  }
 
  public void withPropUsername(String envUsername) {
-  this.propUsername = envUsername;
+  propUsername = envUsername;
  }
 
  public ViolationCommentsToBitbucketServerApi withPullRequestId(int pullRequestId) {
@@ -133,26 +156,4 @@ public ViolationCommentsToBitbucketServerApi withViolations(List<Violation> viol
   this.violations = violations;
   return this;
  }
-
- private void checkState() {
-  if (this.username == null || this.password == null) {
-   throw new IllegalStateException(
-     "User and Password must be set! They can be set with the API or by setting properties.\n" + //
-       "Username/password:\n" + //
-       "-D" + DEFAULT_PROP_VIOLATIONS_USERNAME + "=theuser -D" + DEFAULT_PROP_VIOLATIONS_PASSWORD + "=thepassword");
-  }
-  checkNotNull(this.bitbucketServerUrl, "BitbucketServerURL");
-  checkNotNull(this.pullRequestId, "PullRequestId");
-  checkNotNull(this.repoSlug, "repoSlug");
-  checkNotNull(this.projectKey, "projectKey");
- }
-
- private void populateFromEnvironmentVariables() {
-  if (System.getProperty(this.propUsername) != null) {
-   this.username = firstNonNull(this.username, System.getProperty(this.propUsername));
-  }
-  if (System.getProperty(this.propPassword) != null) {
-   this.password = firstNonNull(this.password, System.getProperty(this.propPassword));
-  }
- }
 }