Increase DNS timeouts#10238
Merged
Gargron merged 1 commit intomastodon:masterfrom Mar 11, 2019
Merged
Conversation
ykzts
approved these changes
Mar 11, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Mar 30, 2020
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at my sidekiq logs, I have found very frequent instances of failure to deliver AP payloads to multiple instances.
Digging a bit, this is because
dns.getaddresses(host)only returned a (sometimes empty) subset of the addresses of those domains.Increasing the timeout got rid of all such errors.