Skip to content

Fix poll update handler calling method was that was not available#10246

Merged
Gargron merged 5 commits intomasterfrom
fix-poll-update-handler
Mar 12, 2019
Merged

Fix poll update handler calling method was that was not available#10246
Gargron merged 5 commits intomasterfrom
fix-poll-update-handler

Conversation

@Gargron
Copy link
Copy Markdown
Member

@Gargron Gargron commented Mar 12, 2019

Fix #10241

@Gargron Gargron added bug Something isn't working work in progress Not to be merged, currently being worked on labels Mar 12, 2019
@Gargron
Copy link
Copy Markdown
Member Author

Gargron commented Mar 12, 2019

@ThibG I have not found the source for the DeliveryWorker problem yet 😕

@ClearlyClaire
Copy link
Copy Markdown
Contributor

@Gargron me neither

Copy link
Copy Markdown
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you overlooked something (inline comment).
Otherwise LGTM.

Comment thread app/lib/activitypub/activity/update.rb Outdated
Comment thread app/services/vote_service.rb Outdated
@Gargron Gargron merged commit 9f5b55a into master Mar 12, 2019
@Gargron Gargron deleted the fix-poll-update-handler branch March 12, 2019 22:16
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…stodon#10246)

* Fix poll update handler calling method was that was not available

Fix regression from mastodon#10209

* Refactor VoteService

* Refactor ActivityPub::DistributePollUpdateWorker and optimize it

* Fix typo

* Fix typo
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
…stodon#10246)

* Fix poll update handler calling method was that was not available

Fix regression from mastodon#10209

* Refactor VoteService

* Refactor ActivityPub::DistributePollUpdateWorker and optimize it

* Fix typo

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working work in progress Not to be merged, currently being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants